Removes crypto dependency so this can be used in edge runtimes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crypto is built into node already https://medium.com/@vviital/you-dont-need-a-uuid-anymore-33cf7ab201d2 Removing cyrpto will allow this to run on cloudflare workers or vercel edge. Additionally added an optional param to LockAcquireConfig allowing someone to pass in their own UUID if they want (or if they don't have the built in crypto module)
|
@EliBates is attempting to deploy a commit to the Upstash Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @EliBates, thanks a lot for the changes! I ran the tests locally and they pass. Merging and releasing a patch. |
CahidArda
approved these changes
Jul 10, 2024
|
@CahidArda Happy to help! Could we get 0.2.1 published to npm when you get a chance? 
|
|
It's now published @EliBates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11
Crypto is built into node already https://medium.com/@vviital/you-dont-need-a-uuid-anymore-33cf7ab201d2 Removing cyrpto will allow this to run on cloudflare workers or vercel edge.
Additionally added an optional param to LockAcquireConfig allowing someone to pass in their own UUID if they want (or if they don't have the built in crypto module)