-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ABA account number assert #240
base: master
Are you sure you want to change the base?
Conversation
* Account number regex. | ||
*/ | ||
|
||
const accountNumberRegex = /^\d{8,17}$/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure about the minimum limit? It seems at ach gateway we're letting min=1...
Can we double check production's db for account number minimum number of digits before deploying this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the information I've read on Plaid's website, I've updated the regexp range from 5 to 17 characters where each character can be:
- a digit
- a lowercase letter
- an uppercase letter
* Account number regex. | ||
*/ | ||
|
||
const accountNumberRegex = /^\d{8,17}$/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we don't seem to be validating the digit-only part. Both ach gateway and backend seem to allow letters, are we sure about this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the information I've read on Plaid's website, I've updated the regexp range from 5 to 17 characters where each character can be:
- a digit
- a lowercase letter
- an uppercase letter
b1ff424
to
3f005dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See @arop comments.
3f005dc
to
6e04f4d
Compare
6e04f4d
to
cf97b56
Compare
cf97b56
to
b5c7c73
Compare
Add ABA account number assert.
Plaid: https://plaid.com/resources/banking/account-numbers-explained/#what-is-an-account-number