-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement opentelemetry mutable baggage #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogotorres97
force-pushed
the
feature/opentelemetry-mutable-baggage
branch
5 times, most recently
from
October 25, 2023 18:14
8970d2a
to
044c493
Compare
diogotorres97
force-pushed
the
support/init-mono-repo
branch
from
October 25, 2023 18:15
176c634
to
3515b34
Compare
diogotorres97
force-pushed
the
feature/opentelemetry-mutable-baggage
branch
from
October 25, 2023 18:18
044c493
to
7982c12
Compare
diogotorres97
force-pushed
the
support/init-mono-repo
branch
from
October 25, 2023 18:24
3515b34
to
a1e8c2a
Compare
diogotorres97
force-pushed
the
feature/opentelemetry-mutable-baggage
branch
3 times, most recently
from
October 25, 2023 19:04
5cf0be3
to
5af03ec
Compare
satazor
force-pushed
the
feature/opentelemetry-mutable-baggage
branch
7 times, most recently
from
October 27, 2023 08:45
bacce08
to
d9d7744
Compare
diogotorres97
force-pushed
the
feature/opentelemetry-mutable-baggage
branch
from
October 27, 2023 09:15
d9d7744
to
19a8eea
Compare
diogotorres97
commented
Oct 27, 2023
diogotorres97
force-pushed
the
feature/opentelemetry-mutable-baggage
branch
from
October 27, 2023 09:39
4e86e82
to
173115b
Compare
satazor
previously approved these changes
Oct 27, 2023
satazor
reviewed
Oct 27, 2023
diogotorres97
force-pushed
the
feature/opentelemetry-mutable-baggage
branch
from
October 27, 2023 13:01
173115b
to
ae4b31d
Compare
satazor
approved these changes
Oct 27, 2023
jspranger
reviewed
Oct 27, 2023
@@ -0,0 +1,22 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to extend https://www.npmjs.com/package/@tsconfig/node18?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We copied over from OTEL TypeScript config and didn't look back
packages/opentelemetry-mutable-baggage/src/w3c-mutable-baggage-propagator.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.