-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document account deletion #217
Open
waldyrious
wants to merge
2
commits into
master
Choose a base branch
from
feature/delete-accounts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
waldyrious
commented
Jul 2, 2021
- Update Account-related information in the Entities section
- Document functionality to delete accounts
waldyrious
force-pushed
the
feature/delete-accounts
branch
from
July 3, 2021 18:04
7df83f1
to
56e97ad
Compare
fmfmartins
reviewed
Jul 5, 2021
_entities.md
Outdated
@@ -20,12 +21,12 @@ | |||
Property | Description | |||
-------- | ----------------------------------------------------------------------- | |||
billing | The relevant billing details associated with the account. | |||
brand | The brand of the `card` account. | |||
brand | The brand of the account (if it is of type `card`). | |||
currency | The currency in which the account is denominated. | |||
id | A unique ID associated with the account. | |||
label | The display name of the account as chosen by the user. | |||
status | The current status of the account. Possible values are `ok` and `failed`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
status | The current status of the account. Possible values are `ok` and `failed`. | |
status | The current status of the account. Possible values are `blocked`, `expired`, `failed`, `ok` and `pending`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to 81f66f3.
waldyrious
force-pushed
the
feature/delete-accounts
branch
from
July 5, 2021 14:05
56e97ad
to
ef5c39b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.