-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APP-186] 계정 통합시, 닉네임 null 예외 처리 #167
Conversation
Bug Fixes
Features
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scrollVIew에 footer 버튼을 하단에 고정시켜려 했지만, scroolView의 컨텐츠들로 인해 아래로 밀리는 현상이 발생했습니다. (아래 링크 참고)
https://uoslifeteam.slack.com/files/U05RPJC7W3U/F067MGGCSQH/________________________________2023-11-25______________1.43.42.mov
그래서 구글링 해본 결과
https://stackoverflow.com/questions/65962363/react-native-fixed-footer-doesnt-stay-on-scroll
https://stackoverflow.com/questions/68108693/how-to-fix-the-footer-on-bottom-of-the-page-in-react-native
https://stackoverflow.com/questions/52986234/how-to-fix-a-view-on-screen-inside-a-scrollview-react-native
https://www.youtube.com/watch?v=4Pw4du1IrDs&t=448s&ab_channel=CatalinMiron (07:10 참고)
위와 같이 abosiute를 사용하라는 조언이 있었지만, 왜인지 저는 scrollView의 크기를 px로 정해주지 않는 이상 여전히 버그가 발생했습니다.
그래서 임의로 scrollView의 크기를 지정해주는 방식으로 문제를 해결했습니다.
Dimensions API를 활용하여 스크린의 높이를 구한 후, scrollView 위에 위치하고 있던 컴포넌트들(Header, Txt)의 높이를 빼주는 방식으로 scrollView의 높이를 구했습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다. 아래와 같은 수정 후 main에 병합하겠습니다. @ratafa
- main branch merge
- map 함수에 key값 추가
- MOCK_DATA 삭제
- isSelected의 타입을 Partial하게 변경
Key Changes
Details
Allocated Issue