Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added setup.py and .gitignore for compatibility with traditional packaging tools #1549

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

muhammad-fiaz
Copy link

Hello, I added a setup.py file alongside a .gitignore for the Unsloth project. Since unsloth uses Poetry for publishing directly to PyPI, I added the setup.py file for compatibility with traditional Python packaging tools and legacy packaging support. The .gitignore is standard for Python projects, ensuring we don't track unnecessary files and keeping things clean.

Note that having both setup.py and pyproject.toml in the same project ensures compatibility with both legacy and modern Python packaging tools. Poetry will still be the main tool for managing dependencies and publishing, but adding setup.py allows the project to work with tools that rely on it. I’ve also made sure the settings in setup.py align with the configurations in pyproject.toml.

Let me know if you need anything adjusted! :)

@muhammad-fiaz muhammad-fiaz changed the title setup.py and .gitignore for compatibility with traditional packaging tools added setup.py and .gitignore for compatibility with traditional packaging tools Jan 16, 2025
@danielhanchen
Copy link
Contributor

Hi - thanks for the PR - I'll review and get back to you - thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants