added setup.py and .gitignore for compatibility with traditional packaging tools #1549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I added a
setup.py
file alongside a.gitignore
for the Unsloth project. Sinceunsloth
uses Poetry for publishing directly to PyPI, I added thesetup.py
file for compatibility with traditional Python packaging tools and legacy packaging support. The.gitignore
is standard for Python projects, ensuring we don't track unnecessary files and keeping things clean.Note that having both
setup.py
andpyproject.toml
in the same project ensures compatibility with both legacy and modern Python packaging tools. Poetry will still be the main tool for managing dependencies and publishing, but addingsetup.py
allows the project to work with tools that rely on it. I’ve also made sure the settings insetup.py
align with the configurations inpyproject.toml
.Let me know if you need anything adjusted! :)