Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Temporary Files (input_embeddings.pt or output_embeddings.pt) Are Saved in Relative Directory #1482

Open
wants to merge 1 commit into
base: nightly
Choose a base branch
from

Conversation

COYLNOR
Copy link

@COYLNOR COYLNOR commented Dec 28, 2024

This PR modifies how temporary files (e.g., input_embeddings.pt and output_embeddings.pt) are stored, addressing the issue mentioned in #905. Specifically, it ensures that these files are saved in a relative directory (_unsloth_temporary_saved_buffers) based on the basename of model.config._name_or_path when it is an absolute path.

This issue has been a challenge for me because the model paths on my server are read-only, and modifications to the original directory were not feasible.

Let me know if there’s anything else to improve!

@danielhanchen danielhanchen changed the base branch from main to nightly January 7, 2025 12:00
@danielhanchen
Copy link
Contributor

Thanks and happy new year! Apologies on the delay.

Could you actually make this an optional try except version - ie can you check if the original location is writeable (and not just readable), and if not then it uses your fix - thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants