Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change BASE to OPFaultRollup / Fix TrustedRollup Types #13

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

adraffy
Copy link
Collaborator

@adraffy adraffy commented Oct 31, 2024

  • change BASE from OPRollup to OPFaultRollup
  • change OPRollup examples using BASE to ZORA
  • moved TrustedRollup out of /eth/ since it works for all chains
  • fixed new TrustedRollup(..., Prover, ...) type
    • could not figure out how to do it the way I wanted
    • using explicit static constructor on each implementation
    • BlockProver has _createFactory() factory generator
  • fixed TrustedRollup interaction with call cache
    • permanent index = 0 caused commit cache to fill up with expired signatures
    • new design uses increasing index

Comment on lines +192 to +194
// case CHAINS.LINEA:
// case CHAINS.LINEA_SEPOLIA:
// return LineaProver;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines should be removed.

Copy link
Collaborator Author

@adraffy adraffy Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these need to stay for the explanatory value. Otherwise, it might seem logical to add them back but the reasoning is pretty nuanced.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. It's more that the block doesn't return a Prover directly now, and the former 4 lines still provide the explanatory value.

scripts/serve.ts Outdated Show resolved Hide resolved
@clowestab clowestab merged commit 78980b4 into main Nov 1, 2024
2 checks passed
@clowestab clowestab deleted the base-fault-type-fix branch November 1, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants