Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change default html element of MenuLabel from label to div #486

Merged
merged 5 commits into from
Nov 2, 2023
Merged

fix: change default html element of MenuLabel from label to div #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
30d763e
fix: change default html element of `MenuLabel` from `label` to `div`
madebyfabian Nov 1, 2023
99e0314
Merge branch 'radix-vue:main' into menu-label-html-tag
madebyfabian Nov 2, 2023
7a14fc9
docs: align label prop with component implementations
madebyfabian Nov 2, 2023
68a2187
fix: change default html element of `SelectLabel` from `label` to `div`
madebyfabian Nov 2, 2023
78d68c1
fix: change default html element of `ComboboxLabel` from `label` to `…
madebyfabian Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/content/components/combobox.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,7 @@ Used to render the label of a group. It won't be focusable using arrow keys.
{
name: 'as',
type: 'string | Component',
default: 'label',
default: 'div',
description: 'The element or component this component should render as. Can be overwrite by <Code>asChild</Code>'
},
{
Expand Down
2 changes: 1 addition & 1 deletion docs/content/components/context-menu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,7 @@ Used to render a label. It won't be focusable using arrow keys.
{
name: 'as',
type: 'string | Component',
default: 'label',
default: 'div',
description: 'The element or component this component should render as. Can be overwrite by <Code>asChild</Code>'
},
{
Expand Down
2 changes: 1 addition & 1 deletion docs/content/components/dropdown-menu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ Used to render a label. It won't be focusable using arrow keys.
{
name: 'as',
type: 'string | Component',
default: 'label',
default: 'div',
description: 'The element or component this component should render as. Can be overwrite by <Code>asChild</Code>'
},
{
Expand Down
2 changes: 1 addition & 1 deletion docs/content/components/menubar.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ Used to render a label. It won't be focusable using arrow keys.
{
name: 'as',
type: 'string | Component',
default: 'label',
default: 'div',
description: 'The element or component this component should render as. Can be overwrite by <Code>asChild</Code>'
},
{
Expand Down
2 changes: 1 addition & 1 deletion docs/content/components/select.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ Used to render the label of a group. It won't be focusable using arrow keys.
{
name: 'as',
type: 'string | Component',
default: 'label',
default: 'div',
description: 'The element or component this component should render as. Can be overwrite by <Code>asChild</Code>'
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/radix-vue/src/Combobox/ComboboxLabel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { Primitive } from '@/Primitive'
import { injectComboboxGroupContext } from './ComboboxGroup.vue'

const props = withDefaults(defineProps<ComboboxLabelProps>(), {
as: 'label',
as: 'div',
})

const groupContext = injectComboboxGroupContext({ id: '' })
Expand Down
2 changes: 1 addition & 1 deletion packages/radix-vue/src/Menu/MenuLabel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export interface MenuLabelProps extends PrimitiveProps {}
import { Primitive } from '@/Primitive'

const props = withDefaults(defineProps<MenuLabelProps>(), {
as: 'label',
as: 'div',
})
</script>

Expand Down
2 changes: 1 addition & 1 deletion packages/radix-vue/src/Select/SelectLabel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { Primitive } from '@/Primitive'
import { injectSelectGroupContext } from './SelectGroup.vue'

const props = withDefaults(defineProps<SelectLabelProps>(), {
as: 'label',
as: 'div',
})

const groupContext = injectSelectGroupContext({ id: '' })
Expand Down
Loading