Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle event.preventDefault() for TooltipTrigger events #459

Closed
wants to merge 1 commit into from
Closed

fix: handle event.preventDefault() for TooltipTrigger events #459

wants to merge 1 commit into from

Conversation

MellKam
Copy link
Collaborator

@MellKam MellKam commented Oct 21, 2023

#377

I had a problem with preventing the default behavior of closing a tooltip on click trigger, because TooltipTrigger was not handling the defaultPrevented case.

@zernonia
Copy link
Member

I've included this in #436, added disableClosingTrigger prop. Could you check that on 1.0.0-beta.2?

@MellKam
Copy link
Collaborator Author

MellKam commented Oct 21, 2023

@zernonia Aaah, this is cool. I haven't seen it.
Then, I'll close this one.

@MellKam MellKam closed this Oct 21, 2023
@MellKam MellKam deleted the fix/handle-prevent-default-for-tooltip-trigger branch December 12, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MellKam @zernonia