Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textbox): accurately clear pending selections even when they're equal to the current selection #19379

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+38 −1
Open

fix(textbox): accurately clear pending selections even when they're equal to the current selection #19379

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b2cd09
fix(textbox): accurately clear pending selections even when they're e…
ramezgerges Jan 30, 2025
e43c7ab
test: add When_Setting_Short_Text_And_Previous_Selection_Is_OutOfBounds
ramezgerges Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1309,6 +1309,10 @@ public void Select(int start, int length)
length = textLength - start;
}

#if __SKIA__
_pendingSelection = null;
#endif
ramezgerges marked this conversation as resolved.
Show resolved Hide resolved

if (SelectionStart == start && SelectionLength == length)
{
return;
Expand Down
1 change: 0 additions & 1 deletion src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.skia.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,6 @@ partial void OnFocusStateChangedPartial(FocusState focusState)

partial void SelectPartial(int start, int length)
{
_pendingSelection = null;
TrySetCurrentlyTyping(false);

if (!_inSelectInternal)
Expand Down
Loading