Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reg): Fix DateTimeFormatter for "day" only #19347

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): closes #19346

@ajpinedam I'll let you verify if this actually fixes it. I made this change only by looking at code

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@ajpinedam
Copy link
Contributor

@Youssef1313, thanks for this. I was looking at it, so I will validate this fix immediately

@ajpinedam ajpinedam self-requested a review January 28, 2025 16:28
@ajpinedam
Copy link
Contributor

It passes Ok. Tested this fix on Sample App:

image

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19347/index.html

@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/5.6

Copy link
Contributor

mergify bot commented Jan 28, 2025

backport release/stable/5.6

✅ Backports have been created

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19347/index.html

@jeromelaban jeromelaban merged commit f84c545 into master Jan 28, 2025
89 of 114 checks passed
@jeromelaban jeromelaban deleted the dev/youssef/datetimeformatter branch January 28, 2025 18:40
jeromelaban added a commit that referenced this pull request Jan 28, 2025
…5.6/pr-19347

fix(reg): Fix DateTimeFormatter for "day" only (backport #19347)
@jeromelaban
Copy link
Member

Thanks @Youssef1313!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(WASM) DatePicker's Day not rendering correctly
4 participants