refactor: Use static Lazy instance for all sensors #19275
Draft
+48
−167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #19274
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Most sensor classes use a static instance and track with an boolean if the instance is already created. This caused code duplication and wasn't implemented like the
LightSensor.cs
implementation.What is the new behavior?
Use a static
Lazy
instance for instance creation, which removes the object lock, as well as the boolean. This follows the implementation already inLightSensor.cs
.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):