Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(devSrv): Remove usage of the deprecated RemoteControl.config file #19262

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix(devSrv): Remove usage of the deprecated RemoteControl.config file #19262

merged 1 commit into from
Jan 17, 2025

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Jan 17, 2025

linked to #19226

Bugfix

Remove usage of the deprecated RemoteControl.config file

What is the current behavior?

If a stale RemoteControl.config file remaining on the disk, it's being considered by uno an breaks configuration of the dev-server endpoint configuration in the application.

What is the new behavior?

Files are ignored in new versions of uno.
Note, thanks to https://github.com/unoplatform/uno.vscode/pull/915 files will be deleted by extensions for older versions of uno.

PR Checklist

@dr1rrb
fix(devSrv): Remove usage of the deprecated RemoteControl.config file…
b7af0f0 
… (cause mis config if a stale file reminas on the disk)
@dr1rrb dr1rrb enabled auto-merge January 17, 2025 14:43
carldebilly
carldebilly approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@carldebilly carldebilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19262/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19262/index.html

@nventive-devops
Copy link
Contributor

The build 152438 found UI Test snapshots differences: android-28-net8: 23, android-28-net8-Snap: 39, ios: 6, ios-Snap: 43, skia-gtk-screenshots: 60, skia-linux-screenshots: 73, skia-windows-screenshots: 60, wasm: 222, wasm-automated-net9.0-UWP-Default-automated: 23, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

  • android-28-net8: 23 changed over 829

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Button_IsEnabled_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Button_IsEnabled_Automated
    • Button_IsOpacity_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Button_Opacity_Automated
    • Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
    • Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
    • Pivot_Non_PivotItemChange_Validation_UITests_Shared_Windows_UI_Xaml_Controls_Pivot_Pivot_CustomContent_Automated
    • Pivot_Non_PivotItem_Items_UITests_Shared_Windows_UI_Xaml_Controls_Pivot_Pivot_CustomContent_Automated
    • Popup_PlacementTest_2Default_HTVL_Uno_UI_Samples_Content_UITests_Popup_Popup_HVAlignments
    • UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
    • When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch

  • android-28-net8-Snap: 39 changed over 1066

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse
    • ItemsRepeater_UITests_Windows_UI_Xaml_Controls_Repeater_StackLayout_Simple_UITests_Windows_UI_Xaml_Controls_Repeater_StackLayout_Simple
    • Scrolling_MUXControlsTestApp_ScrollViewDynamicPage_MUXControlsTestApp_ScrollViewDynamicPage
    • Scrolling_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage
    • TabView_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage
    • Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
    • Icons_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground
    • ListView_ListView_FirstLastCacheIndex_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_FirstLastCacheIndex
    • NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page
    • Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
    • Pointers_UITests_Windows_UI_Input_PointersTests_ScrollHandled_UITests_Windows_UI_Input_PointersTests_ScrollHandled
    • SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
    • WebView_WebView_ChromeClient_Uno_UI_Samples_Content_UITests_WebView_WebView_ChromeClient
    • WebView_WebView_JavascriptInvoke_Uno_UI_Samples_Content_UITests_WebView_WebView_JavascriptInvoke
    • MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • UIElement_UITests_Windows_UI_Xaml_Controls_UIElementCollectionTests_UIElementCollection_Insert_UITests_Windows_UI_Xaml_Controls_UIElementCollectionTests_UIElementCollection_Insert
    • UIElement_UITests_Windows_UI_Xaml_UIElementTests_InlineTextInSpan_UITests_Windows_UI_Xaml_UIElementTests_InlineTextInSpan
    • UIElement_UITests_Windows_UI_Xaml_UIElementTests_UIElement_Alignments_UITests_Windows_UI_Xaml_UIElementTests_UIElement_Alignments

  • ios: 6 changed over 267

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
    • When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220

  • ios-Snap: 43 changed over 1057

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Default_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_CornerRadius_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_CornerRadius
    • Grid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
    • ListView_ListView_Image_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Image
    • SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
    • Brushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrush
    • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse
    • ListView_ListView_TextBox_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_TextBox
    • Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
    • ListView_UITests_Windows_UI_Xaml_Controls_ListView_ListViewItem_IsEnabled_UITests_Windows_UI_Xaml_Controls_ListView_ListViewItem_IsEnabled
    • NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page
    • Clipping_UITests_Windows_UI_Xaml_Clipping_BorderVisualClipping_UITests_Windows_UI_Xaml_Clipping_BorderVisualClipping
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Uno_UI_Samples_UITests_Image_Image_Stretch
    • TextBox_TextBox_Disabled_State_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_Disabled_State
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • ContentControl_ContentControl_UnsetContent_GenericApp_Views_Content_UITests_ContentControlTestsControl_ContentControl_UnsetContent
    • Focus_FocusManagerTest_Uno_UI_Samples_Content_UITests_FocusTests_FocusManagerTest
    • Image_EmptyImageFixedWidth_Uno_UI_Samples_UITests_ImageTestsControl_EmptyImageFixedWidth
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal

  • skia-gtk-screenshots: 60 changed over 2232

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • TransformToVisual_Simple.png-dark
    • TransformToVisual_Simple.png
    • BorderImageBrush.png
    • ImageIconPage.png
    • ListViewHeaderUpdate.png-dark
    • Uniform100x100.png-dark
    • Uniform100x100.png
    • UniformAlignmentCenterInDoubleStackPanelWebUri.png-dark
    • UniformAlignmentCenterInDoubleStackPanelWebUri.png
    • BorderImageBrushRelativeTransform.png-dark
    • CalendarView_Theming.png-dark
    • NetworkInformation.png-dark
    • BorderImageBrush.png-dark
    • Buttons.png-dark
    • BorderImageBrushRelativeTransform.png
    • Gamepad_CurrentReading.png-dark
    • ImageIconPage.png-dark
    • SplitButtonTestsPage.png-dark
    • TextBlock_IsTextSelectionEnabled.png-dark
    • Using .ogg.png-dark

  • skia-linux-screenshots: 73 changed over 2232

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ClipboardTests.png-dark
    • ClipboardTests.png
    • Buttons.png-dark
    • Buttons.png
    • DisplayInformation.png-dark
    • DisplayInformation.png
    • Focus_FocusVisual_Properties.png-dark
    • Focus_FocusVisual_Properties.png
    • ButtonClippingTestsControl.png-dark
    • CalendarView_Theming.png-dark
    • ImageWithLateSourceUniformToFill.png-dark
    • ImageWithLateSourceUniformToFill.png
    • Ellipse.png-dark
    • Ellipse.png
    • ImageIconPage.png-dark
    • ImageIconPage.png
    • DragDrop_TestPage.png-dark
    • DragDrop_TestPage.png
    • Gamepad_Enumeration.png-dark
    • Gamepad_Enumeration.png

  • skia-windows-screenshots: 60 changed over 2232

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • BorderImageBrush.png-dark
    • BorderImageBrush.png
    • Gamepad_CurrentReading.png-dark
    • ClipboardTests.png-dark
    • ButtonClippingTestsControl.png-dark
    • CalendarView_Theming.png-dark
    • DisplayInformation.png-dark
    • DropDownButtonPage.png-dark
    • DropDownButtonPage.png
    • DoubleImageBrushInList.png-dark
    • DoubleImageBrushInList.png
    • Examples.png-dark
    • Examples.png
    • ExpanderColorValidationPage.png-dark
    • ExpanderColorValidationPage.png
    • Image_UseTargetSize.png-dark
    • Image_UseTargetSize.png
    • ButtonClippingTestsControl.png
    • ImageIconPage.png-dark
    • Gamepad_Enumeration.png-dark

  • wasm: 222 changed over 1042

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • MUXControlsTestApp.RefreshVisualizerPage
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_Legacy
    • SamplesApp.Wasm.Windows_UI_Xaml_Media.Transform.Border_With_TranslateTransform
    • SamplesApp.Windows_UI_Xaml.Clipping.DoubleAnimationClipping
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewSelectedItems
    • SamplesApp.Windows_UI_Xaml_Shapes.PolygonPage
    • UITests.Shared.Microsoft_UI_Xaml_Controls.TreeViewTests.TreeViewPage
    • UITests.Shared.Windows_UI_Xaml_Controls.ContentPresenter.ContentPresenter_ImplicitContent
    • UITests.Windows_UI_Composition.Vector3KeyFrameAnimationSample
    • UITests.Windows_UI_Xaml_Controls.ImageTests.BitmapImage_vs_SvgImageSource
    • UITests.Windows_UI_Xaml_Controls.ScrollViewerTests.ScrollViewer_SnapPoints
    • UITests.Windows_UI_Xaml_Controls.SplitView.BindableDrawerLayout_ChangePane
    • UITests.Windows_UI_Xaml_Controls.SplitView.SplitViewClip
    • UITests.Windows_UI_Xaml_Media.ThemeShadowTests.ThemeShadow_CornerRadius
    • MUXControlsTestApp.DropDownButtonPage
    • SamplesApp.Samples.Microsoft_UI_Xaml_Controls.NavigationViewTests.FluentStyle.FluentStyle_NavigationViewSample
    • MUXControlsTestApp.RefreshContainerPage
    • SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_ChromeClient
    • SamplesApp.Samples.RoutedEvents.RoutedEventsPage
    • SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_Static

  • wasm-automated-net9.0-UWP-Default-automated: 23 changed over 1946

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • Default_StrokeThickness_MyEllipse_0_StrokeThickness
    • Default_StrokeThickness_MyLine
    • Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
    • Default_StrokeThickness_MyRect_0_StrokeThickness
    • Border_NonUniformThicknessandRadius_Uno_UI_Samples_UITests_BorderTestsControl_NonUniformThicknessandRadius
    • Default_StrokeThickness_MyPolygon_0_StrokeThickness
    • Default_StrokeThickness_MyPolyline
    • Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • Default_StrokeThickness_MyPath
    • MUX_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPage_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPage
    • ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Basic_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Basic
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage

  • wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1

  • wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1

  • wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

@dr1rrb dr1rrb merged commit f3e1be0 into master Jan 17, 2025
115 checks passed
@dr1rrb dr1rrb deleted the dev/dr/devSrvPortCfg branch January 17, 2025 21:21
@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/5.6

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2025 •
edited
Loading

backport release/stable/5.6

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jan 17, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carldebilly carldebilly carldebilly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dr1rrb @unodevops @nventive-devops @jeromelaban @carldebilly