feat(hr): Add ability to remove root of a DataTemplate with HR without cnomua #19229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/code-generation
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19229/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19229/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19229/index.html |
|
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19229/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19229/index.html |
|
@Mergifyio backport release/stable/5.6 |
✅ Backports have been created
|
|
The build 152272 found UI Test snapshots differences: Details
|
jeromelaban
approved these changes
Jan 17, 2025
6 tasks
jeromelaban
added a commit
that referenced
this pull request
Jan 20, 2025
…5.6/pr-19229 feat(hr): Add ability to remove root of a DataTemplate with HR without cnomua (backport #19229)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/unoplatform/uno.hotdesign/issues/3187
Feature
Add ability to remove root of a
DataTemplatewith HR withoutcnomuaWhat is the current behavior?
Since we removed the
cnomua, we get a rude edit when we remove the root element of aDataTemplateWhat is the new behavior?
We wrap sub classes into a class tagged with
cnomua, so we can remove a sub class (issued for aDataTemplate) without causing a rude-edit.PR Checklist
Screenshots Compare Test Runresults.