fix: Ensure x:Uid is set only when both name and namespace are correct #19148
Conversation
github-actions
bot
added
the
area/code-generation
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19148/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19148/index.html |
|
|
| @@ -3328,7 +3328,8 @@ private void BuildExtendedProperties(IIndentedStringBuilder outerwriter, XamlObj | |||
| { | |||
| writer.AppendLineInvariantIndented("// Load {0}", member.Value); | |||
| } | |||
| else if (member.Member.Name == "Uid") | |||
| else if (member.Member.Name == "Uid" | |||
There was a problem hiding this comment.
This might need to be fixed as well:
There was a problem hiding this comment.
It should be var localizedObject = FindMember(objectDefinition, "Uid", XamlConstants.XamlXmlNamespace)
A test that covers the code path I mentioned may be needed as well.
There was a problem hiding this comment.
Hi @Youssef1313 ! Thanks for the feedback. I'm so sorry for not being able to do this earlier.
A test that covers the code path I mentioned may be needed as well.
Do you mean to add a test for the GenerateFile method? Not sure how to add one for this. Can you give some tips please?
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19148/index.html |
GitHub Issue (If applicable): closes #19069
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When a custom attached property with the name
Uidis attached to an element,x:Uidmight be associated with the target instead. This occurs becausex:Uidis linked to an element solely by its name, not by both name and namespace.What is the new behavior?
x:Uidwon't be linked to an element unless both name and namespace are correctPR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):