-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement the X Input extension to support touch input, smooth scrolling, etc. #15799
Conversation
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15799/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15799/index.html |
@ramezgerges other than the rebase, is there anything missing in this PR? Once it is, I'll test it on actual hardware. |
@jeromelaban There's nothing that I plan to add, no. But considering I haven't tested touch at all, the PR will probably have some stuff "missing. |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15799/index.html |
1 similar comment
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15799/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15799/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15799/index.html |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15799/index.html |
@ramezgerges could you resolve the conflicts? Thanks! |
My version of X input support: https://github.com/lindexi/uno/blob/f2f4d7980fcbf3cef4cbd4a56172e0cb1121aa74/src/Uno.UI.Runtime.Skia.X11/X11PointerInputSource.XInput.cs I tested the code on a touch device and it passed. But there are some points worth discussing:
|
Update: I reimplemente the Reference: #17527 |
@jeromelaban Sorry to be pushing, can I know any update here? |
d403a06
to
900d1da
Compare
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15799/index.html |
1 similar comment
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15799/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15799/index.html |
1 similar comment
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15799/index.html |
@ramezgerges I've never used custom-built/debug Uno SDK before, but if you want me to try your changes please let me know and I'll figure it out. |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15799/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15799/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15799/index.html |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15799/index.html |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15799/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15799/index.html |
Thanks @lindexi for your insights with this PR. |
Excited to see this merged in! Can you comment on which Nuget pre-release package versions I can find this in to do some tests? |
@HakanL It hasn't been automatically published yet, but it should be soon. The current latest sdk version on nuget.org is 5.6.0-dev.10, so most likely the first version after that. |
@ramezgerges I can confirm that I can now scroll with my touchscreen using Uno.Sdk 5.6.0-dev.26! Thank you very much!! |
@ramezgerges Can we expect this to be back-ported to 5.5? |
@HakanL It will go into the next stable release. You can use the prerelease bits in the meantime. |
Yeah, it works well in 5.6 prerelease, it would just be nice to be on a stable version of Uno for my product. But it's okay, I'll wait for 5.6 |
GitHub Issue (If applicable): closes https://github.com/unoplatform/uno-private/issues/409, closes #17912, closes #16804
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):