Skip to content

Commit

Permalink
Merge pull request #19289 from unoplatform/dev/dr/enableDevSrvHR
Browse files Browse the repository at this point in the history
fix(hr): Update HR conditions
  • Loading branch information
jeromelaban authored Jan 22, 2025
2 parents 90e74ea + 873f0ce commit b9eacda
Showing 1 changed file with 3 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -90,20 +90,10 @@ private void CheckMetadataUpdatesSupport()
|| (!Debugger.IsAttached && !buildingInsideVisualStudio && isSkia)

// Mono Debugger under VS Win already handles metadata updates
// Mono Debugger under VS Code prevents metadata based hot reload
// Mono Debugger under VS Code & Rider prevents metadata based hot reload
|| (!Debugger.IsAttached && !buildingInsideVisualStudio && isWasm)

// Disabled until https://github.com/dotnet/runtime/issues/93860 is fixed
//
//||
//(
// buildingInsideVisualStudio.Equals("true", StringComparison.OrdinalIgnoreCase)
// && (
// // As of VS 17.8, when the debugger is not attached, mobile targets can use
// // DevServer's hotreload workspace, as visual studio does not enable it on its own.
// (!Debugger.IsAttached
// && (targetFramework.Contains("-android") || targetFramework.Contains("-ios")))))
;
|| (!Debugger.IsAttached && !buildingInsideVisualStudio && OperatingSystem.IsAndroid())
|| (!Debugger.IsAttached && !buildingInsideVisualStudio && OperatingSystem.IsIOS());

var vsEnabled = isForcedMetadata
|| (buildingInsideVisualStudio && isSkia)
Expand Down

0 comments on commit b9eacda

Please sign in to comment.