feat: Allow disabling the icon background #310
+27
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
TODO docs, waiting for approval that this approach makes sense |
|
@jeromelaban can you confirm this approach works? |
|
This approach is compatible with #239 |
jeromelaban
reviewed
Sep 19, 2024
| @@ -50,6 +50,8 @@ internal class ResizeImageInfo | |||
|
|
|||
| public bool IsAppIcon { get; set; } | |||
|
|
|||
| public bool UseBackgroundFile { get; set; } = true; | |||
There was a problem hiding this comment.
Can you add a test with a validation for this part?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #190
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the user must create a new
.svgfile likeicon_transparent.svgthat is empty and provide it as theUnoIconBackgroundFile- as leaving this empty will fallback toicon.svg.What is the new behavior?
New attribute allows setting
UseIconBackgroundtofalse, which will not use the background file while generating, and will keep the foreground file only instead.I made a follow up PR unoplatform/uno#17855 in Uno.UI to add a prop to control this and then default this to
falseon WASM, desktop and WinUI, where users most commonly don't want a background behind the icon.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):