-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better translation UI #38
Better translation UI #38
Conversation
… unsaved translations from params and b) mark empty saved translations for deletion.
…guage translated.
The default locale can not be removed, otherwise an empty translation will be created.
…untry_flags' into better-translation-ui
@fabn Nice job! I hope this can be merged. |
👍 This is a lovely addition and worked perfectly on a new Rails 4.1 application I've just put together. 🚢. |
Heads up to anyone else trying to debug why 'destroying' a locale does not work in Rails 4. Make sure to put permit_params translations_attributes: [:id, :locale, :your_localisable_attribute, :_destroy] |
@karlfreeman if you're interested in this, I developed it further with some other additions. You can find it on my fork. There's also a demo of additional features for show action here: http://globalize.herokuapp.com/articles/3 |
@stefanoverna are you still interested in maintaining this gem? Otherwise I'll release my fork on rubygems. Let me know |
+1 Nice work. I ran into an issue when trying this out with Rails 4 (Using my own fork based on your pull-request). While
|
I don’t know why this pull request was closed. I just let you know that I use this branch in one of my project and I think it is a very good imrprovement to the existing solution. |
Thanks a lot for letting me know. I did run into an issue but there was no issue tracker enabled on the repo:
The original plugin did that as well which I think is the reason for a problem that I am running into on production environment: Let me know if you decide to enable the issue tracker then I will post issues there. Otherwise I will leave you my feedback here. |
@besi I've just enabled the issue tracker on my fork, feel free to open issues there. |
This pull request bring in #23 and #15 plus an addition to remove existing translations using javascript (see 3f67cfa).
With this the before_filter implemented in #14 is not needed anymore.
I've also relaxed globalize dependency to
~> 3.0.4
to allow usage with rails 3.2.xIf this gets merged #10, #19, #20, #28 and #29 may be closed since all of them will be addressed.
@stefanoverna, @dtengeri, @sepastian let me know if there is something else that should be done.