Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support @Field() option 'complexity' through comment line #216

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tatoBr
Copy link

@tatoBr tatoBr commented May 31, 2024

This pull request enables the use of the 'complexity' option on the @field() decorator with the comment '@Complexity n', where 'n' can be any positive integer.

The following schema:

model User {
  /// @complexity 1
  id        Int      @id
}

will generate this code:

export class UsrUser {
  @Field(() => ID, {nullable:false,complexity:1})
  id!: number;
}

more details at Field-level complexity.

Copy link

@kasir-barati kasir-barati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this PR was opend 7 month ago and frankly speaking IDK why it is still open without any feedback.

@unlight Can you please approve this PR. I really think this is a very important feature since in prod you do not wanna allow your client to be able to send a super heavy query to your backend.

I code reviewed this PR and the only thing I felt missing is some unit/e2e testing @tatoBr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants