Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to blacksmith cache actions #2671

Conversation

aayushshah15
Copy link

@aayushshah15 aayushshah15 commented Nov 21, 2024

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced GitHub Actions workflows with updated runner environments for improved performance.
    • Upgraded actions for setting up Go and Node.js, ensuring better compatibility and functionality.
  • Bug Fixes

    • Improved error handling in pull request title validation, providing clearer feedback to users.
  • Chores

    • Streamlined YAML configurations for better readability and maintenance.

Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: abf2fbe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ blacksmith-sh[bot]
❌ aayushshah15
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

coderabbitai bot commented Nov 21, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request introduces modifications to multiple GitHub Actions workflows. Key changes include updates to the execution environment, transitioning from ubuntu-latest to blacksmith-4vcpu-ubuntu-2204, and upgrades to specific actions, such as changing actions/setup-go to useblacksmith/setup-go and actions/setup-node to useblacksmith/setup-node. The workflows maintain their original logic and structure, focusing on tasks like building, deploying, and testing applications, while also enhancing error handling and streamlining formatting by removing unnecessary blank lines.

Changes

File Path Change Summary
.github/actions/install/action.yaml Updated uses for Go from actions/setup-go@v5 to useblacksmith/setup-go@v6 and caching from actions/cache@v3 to useblacksmith/cache@v5.
.github/workflows/apply-issue-labels-to-pr.yml Changed runs-on from ubuntu-latest to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/autofix.ci.yaml Updated runs-on to blacksmith-4vcpu-ubuntu-2204 and changed Node.js setup from actions/setup-node@v4 to useblacksmith/setup-node@v5.
.github/workflows/build.yaml Changed runs-on to blacksmith-4vcpu-ubuntu-2204 and removed blank lines.
.github/workflows/changesets.yaml Updated runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/deploy.yaml Changed runs-on for multiple jobs to blacksmith-4vcpu-ubuntu-2204, added dependencies, and updated with parameters for api_canary_test and api_preview_test.
.github/workflows/deploy_trigger.yaml Updated runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/job_build_agent_image.yaml Changed runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/job_deploy_agent_production.yaml Updated runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/job_deploy_agent_staging.yaml Changed runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/job_deploy_api_canary.yaml Updated runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/job_deploy_api_enterprise.yaml Changed runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/job_deploy_api_production.yaml Updated runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/job_deploy_api_staging.yaml Changed runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/job_deploy_logdrain_production.yaml Updated runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/job_deploy_semanticcache_production.yaml Changed runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/job_deploy_semanticcache_staging.yaml Updated runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/job_test_agent_integration.yaml Changed runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/job_test_agent_local.yaml Updated runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/job_test_api_canary.yaml Changed runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/job_test_api_local.yaml Updated runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/job_test_api_staging.yaml Changed runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/job_test_unit.yaml Updated runs-on to blacksmith-4vcpu-ubuntu-2204.
.github/workflows/pr-alerts-campsite.yml Changed runs-on to blacksmith-4vcpu-ubuntu-2204 and updated Node.js setup to useblacksmith/setup-node@v5.
.github/workflows/semantic-pull-requests.yaml Updated runs-on to blacksmith-4vcpu-ubuntu-2204 and enhanced error handling for PR title validation.
.github/workflows/test_agent_local.yaml Changed runs-on to blacksmith-4vcpu-ubuntu-2204.

Possibly related PRs

Suggested labels

Feature, Dashboard, 🕹️ oss.gg, :joystick: 300 points

Suggested reviewers

  • perkinsjr
  • chronark

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Nov 21, 2024

@aayushshah15 is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

@aayushshah15 aayushshah15 changed the title 11 21 switch to blacksmith cache actions switch to blacksmith cache actions Nov 21, 2024
Copy link
Contributor

github-actions bot commented Nov 21, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Here is an example:

<type>[optional scope]: <description>
fix: I fixed something for Unkey

Details:

No release type found in pull request title "switch to blacksmith cache actions". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 3:13pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants