Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/add line to oss gg file #2456

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

Khaan25
Copy link
Contributor

@Khaan25 Khaan25 commented Oct 16, 2024

What does this PR do?

This PR adds my name to oss.gg folder and type of quest I've finished.

Fixes #2455

If I'm not wrong, 50 points for following on X and 150 for Starry-eyed supporter

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • You can view the changed files
  • You'll see my contributions :)

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

  • New Features
    • Added participant entry for Zia Ur Rehman in the Unkey X account documentation.
    • Introduced a new "Starry-eyed Supporter" side quest requiring participants to invite friends to star the repository.
  • Updates
    • Enhanced proof of completion for the side quest with new requirements for screenshots and GitHub usernames.
    • Added links to participant's X account and related GitHub issue for better tracking.

Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: c47e614

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 5:16am

Copy link
Contributor

coderabbitai bot commented Oct 16, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request introduces updates to two markdown documents. The first document, oss.gg/3_follow_the_unkey_x_account.md, adds a new entry for participant Zia Ur Rehman, detailing their follow of the Unkey X account on 16-October-2024. The second document, oss.gg/4_starry_eyed_supporter.md, includes a new "Starry-eyed Supporter" side quest entry and logs Zia Ur Rehman's participation in this quest, along with a link to the corresponding GitHub issue.

Changes

File Path Change Summary
oss.gg/3_follow_the_unkey_x_account.md Added entry for Zia Ur Rehman, date of participation (16-October-2024), and link to X account.
oss.gg/4_starry_eyed_supporter.md Updated "Side Quest" section with new entry for "Starry-eyed Supporter" and logged Zia Ur Rehman's participation with a link to GitHub issue.

Assessment against linked issues

Objective Addressed Explanation
Log new participant for "Starry-eyed supporter" (2455)
Include proof of completion requirements (2455)

Possibly related PRs

Suggested reviewers

  • mcstepp
  • chronark
  • perkinsjr
  • MichaelUnkey

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Oct 16, 2024

@Khaan25 is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added Needs Approval Needs approval from Unkey 🕹️ oss.gg labels Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Here is an example:

<type>[optional scope]: <description>
fix: I fixed something for Unkey

Details:

No release type found in pull request title "Chore/add line to oss gg file". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
oss.gg/4_starry_eyed_supporter.md (1)

25-27: LGTM! Minor suggestion for URL formatting.

The changes look good and align with the PR objectives. The entry follows the correct format, includes the necessary information, and provides a link to the corresponding issue.

Consider formatting the URL as a markdown link to improve readability and address the Markdownlint warning:

-» Link to Issue: https://github.com/unkeyed/unkey/issues/2455
+» [Link to Issue](https://github.com/unkeyed/unkey/issues/2455)
🧰 Tools
🪛 Markdownlint

26-26: null
Bare URL used

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between a8b7cd6 and 2f42bd1.

📒 Files selected for processing (2)
  • oss.gg/3_follow_the_unkey_x_account.md (1 hunks)
  • oss.gg/4_starry_eyed_supporter.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
oss.gg/3_follow_the_unkey_x_account.md

35-35: null
Bare URL used

(MD034, no-bare-urls)

oss.gg/4_starry_eyed_supporter.md

26-26: null
Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (1)
oss.gg/3_follow_the_unkey_x_account.md (1)

34-35: LGTM! The new entry is correctly formatted.

The addition follows the existing schema and provides all the required information:

Note: The static analysis tool flagged a bare URL on line 35, but this is part of the required format for this document and can be safely ignored.

🧰 Tools
🪛 Markdownlint

35-35: null
Bare URL used

(MD034, no-bare-urls)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
oss.gg/3_follow_the_unkey_x_account.md (1)

55-56: LGTM! Consider enclosing the URL in angle brackets.

The new entry for Zia Ur Rehman is correctly formatted and contains all the required information. Great job!

For consistency with some other entries and to address a potential markdown linting issue, consider enclosing the URL in angle brackets:

 » 16-October-2024 by [Zia Ur Rehman](@zia_webdev)
-» Link to Account: https://x.com/zia_webdev
+» Link to Account: <https://x.com/zia_webdev>
🧰 Tools
🪛 Markdownlint

56-56: null
Bare URL used

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 2f42bd1 and c47e614.

📒 Files selected for processing (1)
  • oss.gg/3_follow_the_unkey_x_account.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
oss.gg/3_follow_the_unkey_x_account.md

56-56: null
Bare URL used

(MD034, no-bare-urls)

@chronark
Copy link
Collaborator

please add proof of asking friends to star us

@chronark chronark merged commit cd7661f into unkeyed:main Oct 16, 2024
3 of 9 checks passed
Copy link

oss-gg bot commented Oct 16, 2024

Awarding Khaan25: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Khaan25

@Khaan25
Copy link
Contributor Author

Khaan25 commented Oct 16, 2024

FYI, This is the message I sent to my friends:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[oss.gg hackathon] Starry-eyed supporter
2 participants