-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/add line to oss gg file #2456
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces updates to two markdown documents. The first document, Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@Khaan25 is attempting to deploy a commit to the Unkey Team on Vercel. A member of the Team first needs to authorize it. |
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
oss.gg/4_starry_eyed_supporter.md (1)
25-27
: LGTM! Minor suggestion for URL formatting.The changes look good and align with the PR objectives. The entry follows the correct format, includes the necessary information, and provides a link to the corresponding issue.
Consider formatting the URL as a markdown link to improve readability and address the Markdownlint warning:
-» Link to Issue: https://github.com/unkeyed/unkey/issues/2455 +» [Link to Issue](https://github.com/unkeyed/unkey/issues/2455)🧰 Tools
🪛 Markdownlint
26-26: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- oss.gg/3_follow_the_unkey_x_account.md (1 hunks)
- oss.gg/4_starry_eyed_supporter.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
oss.gg/3_follow_the_unkey_x_account.md
35-35: null
Bare URL used(MD034, no-bare-urls)
oss.gg/4_starry_eyed_supporter.md
26-26: null
Bare URL used(MD034, no-bare-urls)
🔇 Additional comments (1)
oss.gg/3_follow_the_unkey_x_account.md (1)
34-35
: LGTM! The new entry is correctly formatted.The addition follows the existing schema and provides all the required information:
- Date: 16-October-2024
- Name: Zia Ur Rehman
- X account link: https://x.com/zia_webdev
Note: The static analysis tool flagged a bare URL on line 35, but this is part of the required format for this document and can be safely ignored.
🧰 Tools
🪛 Markdownlint
35-35: null
Bare URL used(MD034, no-bare-urls)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
oss.gg/3_follow_the_unkey_x_account.md (1)
55-56
: LGTM! Consider enclosing the URL in angle brackets.The new entry for Zia Ur Rehman is correctly formatted and contains all the required information. Great job!
For consistency with some other entries and to address a potential markdown linting issue, consider enclosing the URL in angle brackets:
» 16-October-2024 by [Zia Ur Rehman](@zia_webdev) -» Link to Account: https://x.com/zia_webdev +» Link to Account: <https://x.com/zia_webdev>🧰 Tools
🪛 Markdownlint
56-56: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- oss.gg/3_follow_the_unkey_x_account.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
oss.gg/3_follow_the_unkey_x_account.md
56-56: null
Bare URL used(MD034, no-bare-urls)
please add proof of asking friends to star us |
Awarding Khaan25: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Khaan25 |
What does this PR do?
This PR adds my name to oss.gg folder and type of quest I've finished.
Fixes #2455
If I'm not wrong, 50 points for following on X and 150 for Starry-eyed supporter
If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists
Type of change
How should this be tested?
Checklist
Required
pnpm build
pnpm fmt
console.logs
git pull origin main
Appreciated
Summary by CodeRabbit