-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: follow unkey on X #2323 #2333
Conversation
followed successfully
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@siddhakdak is attempting to deploy a commit to the Unkey Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThe pull request updates the document "oss.gg/3_follow_the_unkey_x_account.md" by adding a new entry for a user named Siddhak dak, who provided their X account handle and link on October 11, 2024. This entry follows the existing format used for documenting participation in the initiative to follow the Unkey X account, while previous entries remain unchanged. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
followed successfully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
oss.gg/3_follow_the_unkey_x_account.md (2)
28-30
: LGTM! Minor formatting suggestion.The new entry for Siddhak dak is correctly formatted and provides all the required information. Great job!
To improve the formatting and address the Markdownlint warning, consider wrapping the URL in angle brackets:
-» Link to Account: https://x.com/DakSiddhak +» Link to Account: <https://x.com/DakSiddhak>This change will make the URL clickable in most Markdown renderers and satisfy the Markdownlint rule.
🧰 Tools
🪛 Markdownlint
29-29: null
Bare URL used(MD034, no-bare-urls)
Line range hint
1-30
: Suggestions for PR description and categorizationThe changes look good, but I have a couple of suggestions to improve the PR:
Consider adding simple testing instructions in the PR description. For example:
"To test: Open the fileoss.gg/3_follow_the_unkey_x_account.md
and verify that the new entry for Siddhak dak is present and correctly formatted."The PR is currently categorized as a "new feature". Since this is a documentation update, it might be more accurate to categorize it as a "documentation" change instead.
🧰 Tools
🪛 Markdownlint
26-26: null
Bare URL used(MD034, no-bare-urls)
29-29: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- oss.gg/3_follow_the_unkey_x_account.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
oss.gg/3_follow_the_unkey_x_account.md
29-29: null
Bare URL used(MD034, no-bare-urls)
🔇 Additional comments (1)
oss.gg/3_follow_the_unkey_x_account.md (1)
Line range hint
1-30
: Overall changes look good!The new entry for Siddhak dak has been added correctly, maintaining consistency with existing entries and preserving the overall document structure. The instructions and point value at the top of the document remain unchanged, which is correct.
🧰 Tools
🪛 Markdownlint
26-26: null
Bare URL used(MD034, no-bare-urls)
29-29: null
Bare URL used(MD034, no-bare-urls)
you need to sign the CLA please |
@siddhakdak please sign the CLA and resolve the merge conflicts |
/award 50 |
Awarding siddhakdak: 50 points 🕹️ Well done! Check out your new contribution on oss.gg/siddhakdak |
followed successfully
What does this PR do?
Fixes # 2323
Type of change
oss.gg side quest challenge: Follow the Unkey X account
How should this be tested?
Checklist
Required
pnpm build
pnpm fmt
console.logs
git pull origin main
Appreciated
Summary by CodeRabbit
New Features
Documentation