Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: follow unkey on X #2323 #2333

Closed
wants to merge 1 commit into from
Closed

Conversation

siddhakdak
Copy link

@siddhakdak siddhakdak commented Oct 11, 2024

followed successfully

What does this PR do?

Fixes # 2323

Type of change

oss.gg side quest challenge: Follow the Unkey X account

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • [X ] Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary
Screenshot 2024-10-11 at 3 55 10 PM

Summary by CodeRabbit

  • New Features

    • Added a new entry for user Siddhak dak, including their X account handle and link for the side quest participation.
  • Documentation

    • Updated the document to reflect the new entry while maintaining the existing format for previous participants.

Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: 78b1d04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 10:26am

Copy link

vercel bot commented Oct 11, 2024

@siddhakdak is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Oct 11, 2024

📝 Walkthrough

Walkthrough

The pull request updates the document "oss.gg/3_follow_the_unkey_x_account.md" by adding a new entry for a user named Siddhak dak, who provided their X account handle and link on October 11, 2024. This entry follows the existing format used for documenting participation in the initiative to follow the Unkey X account, while previous entries remain unchanged.

Changes

File Path Change Summary
oss.gg/3_follow_the_unkey_x_account.md Added new entry for Siddhak dak with account handle and link.

Possibly related PRs

  • feat: Follow the Unkey X account #2240: This PR also updates the "Follow the Unkey X account" document, adding a new entry for a user, which is directly related to the changes made in the main PR.

Suggested labels

🕹️ oss.gg, :joystick: 50 points

Suggested reviewers

  • chronark

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@siddhakdak
Copy link
Author

followed successfully

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
oss.gg/3_follow_the_unkey_x_account.md (2)

28-30: LGTM! Minor formatting suggestion.

The new entry for Siddhak dak is correctly formatted and provides all the required information. Great job!

To improve the formatting and address the Markdownlint warning, consider wrapping the URL in angle brackets:

-» Link to Account: https://x.com/DakSiddhak
+» Link to Account: <https://x.com/DakSiddhak>

This change will make the URL clickable in most Markdown renderers and satisfy the Markdownlint rule.

🧰 Tools
🪛 Markdownlint

29-29: null
Bare URL used

(MD034, no-bare-urls)


Line range hint 1-30: Suggestions for PR description and categorization

The changes look good, but I have a couple of suggestions to improve the PR:

  1. Consider adding simple testing instructions in the PR description. For example:
    "To test: Open the file oss.gg/3_follow_the_unkey_x_account.md and verify that the new entry for Siddhak dak is present and correctly formatted."

  2. The PR is currently categorized as a "new feature". Since this is a documentation update, it might be more accurate to categorize it as a "documentation" change instead.

🧰 Tools
🪛 Markdownlint

26-26: null
Bare URL used

(MD034, no-bare-urls)


29-29: null
Bare URL used

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 0608fee and 78b1d04.

📒 Files selected for processing (1)
  • oss.gg/3_follow_the_unkey_x_account.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
oss.gg/3_follow_the_unkey_x_account.md

29-29: null
Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (1)
oss.gg/3_follow_the_unkey_x_account.md (1)

Line range hint 1-30: Overall changes look good!

The new entry for Siddhak dak has been added correctly, maintaining consistency with existing entries and preserving the overall document structure. The instructions and point value at the top of the document remain unchanged, which is correct.

🧰 Tools
🪛 Markdownlint

26-26: null
Bare URL used

(MD034, no-bare-urls)


29-29: null
Bare URL used

(MD034, no-bare-urls)

@chronark
Copy link
Collaborator

you need to sign the CLA please

@chronark
Copy link
Collaborator

@siddhakdak please sign the CLA and resolve the merge conflicts

@MichaelUnkey
Copy link
Collaborator

/award 50

Copy link

oss-gg bot commented Oct 15, 2024

Awarding siddhakdak: 50 points 🕹️ Well done! Check out your new contribution on oss.gg/siddhakdak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants