fix: refine next 22 of 38 lint warnings (#2660)

* fix: delete unused components

* fix: resolve 17 of 33 lint warnings

* fix: remove unused parameter from component props

* fix: remove excessive optional chaining (?.) operator

apps/dashboard/app/(app)/authorization/roles/create-new-role.tsx

@@ -58,7 +58,7 @@ const formSchema = z.object({
     .optional(),
 });
 
-export const CreateNewRole: React.FC<Props> = ({ trigger, permissions }) => {
+export const CreateNewRole: React.FC<Props> = ({ trigger }) => {
   const router = useRouter();
   const [open, setOpen] = useState(false);
 

apps/dashboard/app/(app)/settings/general/update-workspace-image.tsx

@@ -57,7 +57,7 @@ export const UpdateWorkspaceImage: React.FC = () => {
           toast.error("Error uploading image");
         });
     },
-    [setImage, organization],
+    [organization],
   );
 
   if (!organization) {

apps/dashboard/app/(app)/settings/user/update-user-image.tsx

@@ -57,7 +57,7 @@ export const UpdateUserImage: React.FC = () => {
           toast.error("Error uploading image");
         });
     },
-    [setImage, user],
+    [user],
   );
 
   return (

apps/dashboard/components/multi-select.tsx

@@ -39,25 +39,28 @@ export const MultiSelect: React.FC<Props> = ({ options, placeholder, selected, s
     setSelected((prev) => prev.filter((s) => s.value !== o.value));
   };
 
-  const handleKeyDown = React.useCallback((e: React.KeyboardEvent<HTMLDivElement>) => {
-    const input = inputRef.current;
-    if (input) {
-      if (e.key === "Delete" || e.key === "Backspace") {
-        if (input.value === "") {
-          setSelected((prev) => {
-            const newSelected = [...prev];
-            newSelected.pop();
-            return newSelected;
-          });
+  const handleKeyDown = React.useCallback(
+    (e: React.KeyboardEvent<HTMLDivElement>) => {
+      const input = inputRef.current;
+      if (input) {
+        if (e.key === "Delete" || e.key === "Backspace") {
+          if (input.value === "") {
+            setSelected((prev) => {
+              const newSelected = [...prev];
+              newSelected.pop();
+              return newSelected;
+            });
+          }
         }
-      }
 
-      // This is not a default behaviour of the <input /> field
-      if (e.key === "Escape") {
-        input.blur();
+        // This is not a default behaviour of the <input /> field
+        if (e.key === "Escape") {
+          input.blur();
+        }
       }
-    }
-  }, []);
+    },
+    [setSelected],
+  );
 
   const selectables = options.filter((o) => !selected.includes(o));
 

apps/dashboard/lib/charts/sparkline.tsx

@@ -89,7 +89,7 @@ function SparkLineInner<T extends Datum>({
         range: [0, width],
       }),
     };
-  }, [startDate, endDate, minY, maxY, height, width]);
+  }, [startDate, endDate, minY, maxY, height, width, padding.bottom, padding.top]);
 
   const chartContext: ChartContextType<T> = {
     width,

apps/dashboard/lib/charts/time-series-chart.tsx

@@ -62,7 +62,7 @@ function TimeSeriesChartInner<T extends Datum>({
       startDate: dates[times.indexOf(Math.min(...times))],
       endDate: dates[times.indexOf(Math.max(...times))],
     };
-  }, data);
+  }, [data]);
 
   const { minY, maxY } = useMemo(() => {
     const values = series
@@ -74,7 +74,7 @@ function TimeSeriesChartInner<T extends Datum>({
       minY: Math.min(...values),
       maxY: Math.max(...values),
     };
-  }, [data, series, padding?.bottom, padding?.top]);
+  }, [data, series]);
 
   const { yScale, xScale } = useMemo(() => {
     const rangeY = maxY - minY;
@@ -90,7 +90,7 @@ function TimeSeriesChartInner<T extends Datum>({
         range: [0, width],
       }),
     };
-  }, [startDate, endDate, minY, maxY, height, width, margin]);
+  }, [startDate, endDate, minY, maxY, height, width, padding?.bottom, padding?.top]);
 
   const chartContext: ChartContextType<T> = {
     width,

apps/dashboard/lib/charts/useTooltip.ts

@@ -50,7 +50,17 @@ export function useTooltip<T extends Datum>({
         tooltipTop: snapToY ? yScale(series.find((s) => s.id === seriesId)!.valueAccessor(d)) : 0,
       });
     },
-    [seriesId, data, xScale, yScale, series, visxTooltip.showTooltip],
+    [
+      seriesId,
+      data,
+      xScale,
+      yScale,
+      series,
+      margin.left,
+      snapToX,
+      snapToY,
+      visxTooltip.showTooltip,
+    ],
   );
 
   const TooltipWrapper = renderInPortal ? visxTooltipInPortal.TooltipInPortal : TooltipWithBounds;

apps/play/app/page-bk.tsx

@@ -20,8 +20,8 @@ export default function Home() {
   const scrollRef = useRef<null | HTMLDivElement>(null);
 
   useEffect(() => {
-    scrollRef?.current?.scrollIntoView({ behavior: "smooth" });
-  }, [scrollRef]);
+    scrollRef.current?.scrollIntoView({ behavior: "smooth" });
+  }, []);
 
   const parseCurlCommand = useCallback(
     (stepString: string) => {
@@ -34,7 +34,7 @@ export default function Home() {
       tempString = keyName.current ? tempString.replace("<key>", keyName.current) : tempString;
       return tempString;
     },
-    [apiId, keyId, keyName, timeStamp],
+    [apiId],
   );
   function handleSubmit(cmd: string) {
     postNewLine(cmd, "text-violet-500");

apps/www/app/accelerate/components/rive.tsx

@@ -98,7 +98,7 @@ const RiveAccelerateAsset = ({ day, stateMachines }: { day: number; stateMachine
     r.rive.on(EventType.RiveEvent, onRiveEventReceived);
 
     setDone(true);
-  }, [done, r.rive, smVarHighlight, smVarUnlockedUntil]);
+  }, [done, day, r.rive, smVarHighlight, smVarUnlockedUntil]);
 
   return <r.RiveComponent />;
 };