fix: trim spaces in strings for names (#2527)

* trim names in dashboard

* [autofix.ci] apply automated fixes

* missed changes

* [autofix.ci] apply automated fixes

* Changed method for trim

* [autofix.ci] apply automated fixes

* missed min max

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/[keyId]/settings/update-key-name.tsx

@@ -24,6 +24,7 @@ const formSchema = z.object({
   keyId: z.string(),
   name: z
     .string()
+    .trim()
     .transform((e) => (e === "" ? undefined : e))
     .optional(),
 });

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/[keyId]/settings/update-key-owner-id.tsx

@@ -24,6 +24,7 @@ const formSchema = z.object({
   keyId: z.string(),
   ownerId: z
     .string()
+    .trim()
     .transform((e) => (e === "" ? undefined : e))
     .optional(),
 });

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/new/client.tsx

@@ -57,10 +57,11 @@ const formSchema = z.object({
     .default(16),
   prefix: z
     .string()
+    .trim()
     .max(8, { message: "Please limit the prefix to under 8 characters." })
     .optional(),
-  ownerId: z.string().optional(),
-  name: z.string().optional(),
+  ownerId: z.string().trim().optional(),
+  name: z.string().trim().optional(),
   metaEnabled: z.boolean().default(false),
   meta: z
     .string()

apps/dashboard/app/(app)/apis/[apiId]/settings/update-api-name.tsx

@@ -21,7 +21,7 @@ import { z } from "zod";
 import { tags } from "@/lib/cache";
 import { revalidateTag } from "../../../../actions";
 const formSchema = z.object({
-  name: z.string(),
+  name: z.string().trim().min(3, "Name is required and should be at least 3 characters"),
   apiId: z.string(),
   workspaceId: z.string(),
 });

apps/dashboard/app/(app)/apis/create-api-button.tsx

@@ -23,7 +23,7 @@ import { useForm } from "react-hook-form";
 import { z } from "zod";
 
 const formSchema = z.object({
-  name: z.string().min(2).max(50),
+  name: z.string().trim().min(3, "Name must be at least 3 characters long").max(50),
 });
 
 export const CreateApiButton = ({ ...rest }: React.ButtonHTMLAttributes<HTMLButtonElement>) => {

apps/dashboard/app/(app)/authorization/roles/[roleId]/update-role.tsx

@@ -38,7 +38,13 @@ type Props = {
 };
 
 const formSchema = z.object({
-  name: z.string(),
+  name: z
+    .string()
+    .min(3)
+    .regex(/^[a-zA-Z0-9_:\-\.\*]+$/, {
+      message:
+        "Must be at least 3 characters long and only contain alphanumeric, colons, periods, dashes and underscores",
+    }),
   description: z.string().optional(),
 });
 

apps/dashboard/app/(app)/ratelimits/[namespaceId]/overrides/create-new-override.tsx

@@ -28,7 +28,11 @@ import { useForm } from "react-hook-form";
 import { z } from "zod";
 
 const formSchema = z.object({
-  identifier: z.string().min(2).max(250),
+  identifier: z
+    .string()
+    .trim()
+    .min(3, "Name is required and should be at least 3 characters")
+    .max(250),
   limit: z.coerce.number().int().min(1).max(10_000),
   duration: z.coerce
     .number()

apps/dashboard/app/(app)/ratelimits/[namespaceId]/settings/update-namespace-name.tsx

@@ -20,7 +20,15 @@ import { useRouter } from "next/navigation";
 import { useForm } from "react-hook-form";
 import { z } from "zod";
 const formSchema = z.object({
-  name: z.string(),
+  name: z
+    .string()
+    .trim()
+    .min(3)
+    .max(50)
+    .regex(/^[a-zA-Z0-9_\-\.]+$/, {
+      message:
+        "Name must be 3-50 characters long and can only contain letters, numbers, underscores, hyphens, and periods.",
+    }),
   namespaceId: z.string(),
   workspaceId: z.string(),
 });
@@ -56,7 +64,7 @@ export const UpdateNamespaceName: React.FC<Props> = ({ namespace }) => {
   });
   async function onSubmit(values: z.infer<typeof formSchema>) {
     if (values.name === namespace.name || !values.name) {
-      return toast.error("Please provide a valid name before saving.");
+      return toast.error("Please provide a different name before saving.");
     }
     await updateName.mutateAsync(values);
   }

apps/dashboard/app/(app)/ratelimits/create-namespace-button.tsx

@@ -22,7 +22,15 @@ import { useForm } from "react-hook-form";
 import { z } from "zod";
 
 const formSchema = z.object({
-  name: z.string().regex(/^[a-zA-Z0-9_\-\.]{3,50}$/),
+  name: z
+    .string()
+    .trim()
+    .min(1, "Name must not be empty")
+    .max(50, "Name must not exceed 50 characters")
+    .regex(
+      /^[a-zA-Z0-9_\-\.]+$/,
+      "Only alphanumeric characters, underscores, hyphens, and periods are allowed",
+    ),
 });
 
 export const CreateNamespaceButton = ({

apps/dashboard/app/(app)/settings/general/update-workspace-name.tsx

@@ -18,7 +18,7 @@ const validCharactersRegex = /^[a-zA-Z0-9-_]+$/;
 
 const formSchema = z.object({
   workspaceId: z.string(),
-  name: z.string().min(3).regex(validCharactersRegex, {
+  name: z.string().trim().min(3).regex(validCharactersRegex, {
     message: "Workspace can only contain letters, numbers, dashes, and underscores",
   }),
 });

apps/dashboard/app/new/create-api.tsx

@@ -22,7 +22,7 @@ import { useRouter } from "next/navigation";
 import { useForm } from "react-hook-form";
 import { z } from "zod";
 const formSchema = z.object({
-  name: z.string().min(3, "Name is required and should be at least 3 characters").max(50),
+  name: z.string().trim().min(3, "Name is required and should be at least 3 characters").max(50),
 });
 
 type Props = {

apps/dashboard/app/new/create-workspace.tsx

@@ -23,7 +23,7 @@ import { useForm } from "react-hook-form";
 import { z } from "zod";
 
 const formSchema = z.object({
-  name: z.string().min(3, "Name is required and should be at least 3 characters").max(50),
+  name: z.string().trim().min(3, "Name is required and should be at least 3 characters").max(50),
 });
 
 export const CreateWorkspace: React.FC = () => {