Bugfix/763: DataFrameModel validate returns the correct type #1450
+27
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the return type casting of various model methods to return the correct type (
DataFrame
instead ofDataFrameBase
). The issue called for typing overload but that didn't seem to be necessary in looking at the code, because as best as I can tell calling these methods should always return the same thing (andDataFrame
inherits fromDataFrameBase
anyway).Resolves #763