Add the dependency analyser with the go toolchain to kraft (V2) #21
Conversation
This patch adds a new series of commands devel which allows to interact with the go toolchain. For now, only the dependency analyser has been added to the kraft tool. The go binaries are directly integrated to the kraft repo which allows to avoid the setup and the installation of the go runtime. Signed-off-by: Gaulthier Gain <[email protected]>
This patch adds new entries point to the Makefile in order to build the go toolchain as a container for the CI system. Signed-off-by: Gaulthier Gain <[email protected]>
| --cache-from $(ORG)/gotools:$(GO_VERSION) \ | ||
| --cache-from $(IMAGE_NAME) \ | ||
| --file $(DOCKERDIR)/Dockerfile.gotools \ | ||
| $(DOCKER_BUILD_EXTRA) $(DOCKERDIR) |
There was a problem hiding this comment.
This may have to be $(KRAFTDIR) and not $(DOCKERDIR), but I will check when I run the build myself
| VOLUME [${SHARED_DIR}] | ||
|
|
||
| RUN set -xe | ||
| RUN chmod +x ./tools_Linux |
There was a problem hiding this comment.
Likely this file can be put into the Dockerfile verbatim as it won't be run outside
There was a problem hiding this comment.
I've just seen this is a binary. The Dockerfile is intended to build go files?
There was a problem hiding this comment.
What do you mean by binary? Creating the binary from sources only in the Dockerfile ?
| import platform | ||
| import subprocess | ||
|
|
||
| TOOLS_PATH = './package/docker/gotools/tools_' |
There was a problem hiding this comment.
This may be dependent on where how the package is installed, the extra binaries can be referenced globally, no?
There was a problem hiding this comment.
You mean, using an absolute path?
There was a problem hiding this comment.
No, the TOOLS_PATH may just need to call a method to determine where the binaries were installed on the system. I will check this.
|
@nderjung Actually, I used the binaries for the host platform and docker. In your opinion, binaries must only be used with the host platform (without docker). Right? |
These binaries should still not be commited via git. |
|
I think i can turn this thread into a draft and you can push updates here? I wonder if you're allowed to re-stage commits to this though... |
|
Superceded (#22). |
Add the dependency analyser with the go toolchain to kraft.
This patch adds a new series of commands
develwhich allowsto interact with the go toolchain. For now, only the dependency
analyser has been added to the kraft tool.