Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[US-395] Add example code for multifont encoder #247

Conversation

kellemNegasi
Copy link
Contributor

No description provided.

@kellemNegasi kellemNegasi marked this pull request as ready for review May 2, 2024 16:22
Copy link
Contributor

@sampila sampila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, added minor comment

}

// getFonts returns list of *model.PdfFont from list of paths to fonts files.
func getFonts(fontPaths []string) []*model.PdfFont {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this name will be better setCompositeTTFPdfFonts?

Copy link
Contributor Author

@kellemNegasi kellemNegasi May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that seems more expressive. may be use_composite_TTFPdfFonts

Copy link
Contributor

@3ace 3ace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kellemNegasi kellemNegasi requested a review from sampila May 2, 2024 17:09
@anovik anovik merged commit 59c11f7 into unidoc:master May 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants