ICU-22940 MF2 ICU4C: Update for bidi support #3236
Conversation
catamorphism
force-pushed
the
bidi-tests
branch
from
911d047
to
703002a
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
catamorphism
force-pushed
the
bidi-tests
branch
from
703002a
to
01d2fdc
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
catamorphism
changed the title
| inRange(c, 0x00F8, 0x02FF) || inRange(c, 0x0370, 0x037D) || inRange(c, 0x037F, 0x1FFF) || | ||
| inRange(c, 0x200C, 0x200D) || inRange(c, 0x2070, 0x218F) || inRange(c, 0x2C00, 0x2FEF) || | ||
| inRange(c, 0x00F8, 0x02FF) || inRange(c, 0x0370, 0x037D) || inRange(c, 0x037F, 0x061B) || | ||
| inRange(c, 0x061D, 0x200D) || inRange(c, 0x2070, 0x218F) || inRange(c, 0x2C00, 0x2FEF) || |
There was a problem hiding this comment.
@catamorphism i see ALM is not namestart, but this change makes U+2000…U+200B isNameStart true. they are dashes and spaces, and not ID_Start
There was a problem hiding this comment.
BTW, I think this would be far more reliable in using a UnicodeSet. That can be created as the C++ equivalent of a static final immutable object.
There was a problem hiding this comment.
@srl295 Fixed
@macchiati Done in 780a947
| @@ -125,7 +125,13 @@ static bool isContentChar(UChar32 c) { | |||
| || inRange(c, 0xE000, 0x10FFFF); | |||
| } | |||
|
|
|||
| // See `s` in the MessageFormat 2 grammar | |||
| // See `bidi` in the MF2 grammar | |||
| static bool isBidi(UChar32 c) { | |||
There was a problem hiding this comment.
maybe isBidiControl might be better?
There was a problem hiding this comment.
Done in 780a947
The tests in this PR are also included in a PR against the MF2 spec. However, some editing will have to occur unless #3198 (matching on variables instead of expressions) lands before then. There was a spec change to the syntax of
.matchconstructs, and some of the tests include.matchconstructs.Checklist