-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Density probability distribution calculation #441
base: develop
Are you sure you want to change the base?
Conversation
This version doesn't throw an error if it cannot load all particles, I need to look at that before merging. |
|
||
h5reader->closeStep(); | ||
|
||
T localTotalDensity = 0.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable should be double
to avoid loss of precision. (rho
in float
is fine)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But: why do you even compute this, instead of just dividing the total mass by the volume of the simulation box?
Adds a parallel implementation to calculate the Density probability distribution function for the turbulence test