Density probability distribution calculation #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmcabezon
reviewed
Apr 17, 2024
rmcabezon
reviewed
Apr 23, 2024
|
This version doesn't throw an error if it cannot load all particles, I need to look at that before merging. |
sekelle
reviewed
Apr 29, 2024
|
|
||
| h5reader->closeStep(); | ||
|
|
||
| T localTotalDensity = 0.0; |
There was a problem hiding this comment.
This variable should be double to avoid loss of precision. (rho in float is fine)
There was a problem hiding this comment.
But: why do you even compute this, instead of just dividing the total mass by the volume of the simulation box?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a parallel implementation to calculate the Density probability distribution function for the turbulence test