Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new mobile image position prop with default at center (#1323) #1326

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

CalebLuster
Copy link
Collaborator

#1323 - added Mobile image position field.

Copy link

cloudflare-workers-and-pages bot commented Jul 1, 2024

Deploying design-system with  Cloudflare Pages  Cloudflare Pages

Latest commit: ca09cec
Status: ✅  Deploy successful!
Preview URL: https://b45d303c.design-system.pages.dev
Branch Preview URL: https://issue-1323-object-position-o.design-system.pages.dev

View logs

@Jura
Copy link
Member

Jura commented Jul 1, 2024

@CalebLuster , I can't see the control in the UI: https://issue-1323-object-position-o.design-system.pages.dev/?path=/story/components-ui-components-hero-page-pagehero--page-hero-full-width
I mean it has to be applied primarily to the "Page hero full width" component. Although applying to the "tall image" variant make sense as well as image will be displayed full width on small screens, so keep it there. But the option should be also functional for the "Full width" option.

@Jura Jura merged commit 2e0a2aa into develop Jul 2, 2024
5 checks passed
@Jura Jura deleted the issue-1323-object-position-option branch December 14, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants