Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tokenization #191

Merged
merged 19 commits into from
Aug 6, 2023
Merged

Refactor tokenization #191

merged 19 commits into from
Aug 6, 2023

Commits on Aug 3, 2023

  1. test_cfg_post_init working

    mivanit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    aea5144 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    973fef4 View commit details
    Browse the repository at this point in the history
  3. wip

    mivanit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    457e2b0 View commit details
    Browse the repository at this point in the history
  4. wip

    mivanit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    1cc3644 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    be96003 View commit details
    Browse the repository at this point in the history
  6. test_tokenizers passing

    mivanit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    c80bc2a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a3366af View commit details
    Browse the repository at this point in the history
  8. poetry lock

    mivanit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    3355c24 View commit details
    Browse the repository at this point in the history
  9. format

    mivanit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    1142760 View commit details
    Browse the repository at this point in the history
  10. remove deprecated kwarg to process_weights_

    Upgrading transformer_lens to 1.4.0 caused
    `HookedTransformer.process_weights_()` to no longer accept
    the keyword arg `move_state_dict_to_device`
    
    However, I'm not sure if this was important in the first place.
    If any issues come up, move the state dict to device manually in
    `ZanjHookedTransformer._load_state_dict_wrapper()` where all this
    was happening in the first place
    mivanit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    571acd8 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    9114d86 View commit details
    Browse the repository at this point in the history
  12. updated changed dataset config key

    since we removed tokenizer stuff from the dataset
    mivanit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    2ee2f3e View commit details
    Browse the repository at this point in the history
  13. fixed eval_model nb, added ZanjHookedTransformer.config ref

    the `eval_model.ipynb` notebook has a function `testdata_plot_predicted_path`
    which was using `model.zanj_model_config` to get the tokenizer, an attribute
    missing from the `RandomBaseline` class since it only inherits from `HookedTransformer`
    
    to fix this:
    
    - `ZanjHookedTransformer` now has a `config` property which just
      accesses the `zanj_model_config` used by the parent `ConfiguredModel`
    - `testdata_plot_predicted_path` now uses `model.config` everywhere
    mivanit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    a06378d View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    933e013 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2023

  1. fixed minor import issue

    mivanit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    234175e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a23e2c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. lock poetry, re-run notebook

    mivanit committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    144daa8 View commit details
    Browse the repository at this point in the history
  2. format

    mivanit committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    16bc51e View commit details
    Browse the repository at this point in the history
  3. update coverage

    mivanit committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    5a577a1 View commit details
    Browse the repository at this point in the history