Fix validateOutputAmount API for BigNumber #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bucko13
reviewed
Dec 15, 2023
fix: preserve backward compatibility
Shadouts
force-pushed
the
prevent-bignumber-exposure
branch
from
9ee5cd4 to
fc03111
Compare
|
I've changed this to offer backward compatibility on the function. Any future major version should remove the BigNumber type from the arg. |
bucko13
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outputs/validateOutputAmountis requiring a BigNumber type on its args. This leaks lib dependencies onto the caller. Previously a version of unchained-bitcoin had removed the BigNumber dependency from its API. This function must have been missed.Unfortunately this change would require a major version increment since an arg type is updating and breaking backward compatibility.