Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: c4gh config #267

Merged
merged 5 commits into from
Sep 24, 2024
Merged

refactor: c4gh config #267

merged 5 commits into from
Sep 24, 2024

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Sep 24, 2024 •
edited
Loading

Related to points in #262 (comment).

Changes

  • Removes the object_type wrapper for configuring C4GH keys in favour of passing them in directly.
  • Refactors storage configuration to prefer more explicitly defining the type.
    • The type of storage now needs to be specified as either Local, S3 or Url.
    • I think this change leads to less confusion about which type is being used.

@mmalenic mmalenic self-assigned this Sep 24, 2024
@mmalenic mmalenic added the refactor changes related to code refactoring label Sep 24, 2024
@mmalenic mmalenic added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit a34e332 Sep 24, 2024
5 checks passed
@mmalenic mmalenic deleted the refactor/c4gh-config branch September 24, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainstorm brainstorm brainstorm approved these changes

Assignees

@mmalenic mmalenic

Labels
refactor changes related to code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmalenic @brainstorm