Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prototype to support SkipList keys #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vkuznet
Copy link

@vkuznet vkuznet commented Mar 25, 2022

Hi,
based on my understanding of the code the WhiteList can be easily added. The prototype of changes is presented in this PR. Of course, this can be further extended along with requirements and guidelines of the main codebase. Any feedback is welcome here.

@vkuznet
Copy link
Author

vkuznet commented Mar 25, 2022

The proposed usage would be:

wlist := []string{"::1"}
instance := limiter.New(store, rate, limiter.WithSkipList(wlist))

@vkuznet vkuznet changed the title Add prototype to support WhiteList keys Add prototype to support SkipList keys Mar 28, 2022
@vkuznet
Copy link
Author

vkuznet commented Mar 28, 2022

renamed whitelist to be skiplist to avoid reported here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant