Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax restriction on Python version #2

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

hsaunders1904
Copy link
Contributor

@hsaunders1904 hsaunders1904 commented Nov 17, 2023

Description

Allows use of the hook when using Python versions 3.8 - 3.12. These are the versions supported by PySide6, so we should also support them.

We should probably support all Python versions that PySide6 supports.
That's 3.8 - 3.12.
Copy link
Contributor

@DanShort12 DanShort12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the one comment on version coverage for the tests.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@hsaunders1904 hsaunders1904 merged commit 26cae05 into main Nov 20, 2023
6 checks passed
@hsaunders1904 hsaunders1904 deleted the hsaunders1904/relax_restriction_on_python_version branch November 20, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants