Migrate hook to GitHub #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanShort12
force-pushed
the
github-migration
branch
from
00b0afd
to
be463ba
Compare
hsaunders1904
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Thanks for this! Sorry about the script bug. I did rename things from uic-pre-commit to pyuic-pre-commit at one point, so obviously missed an instance. Not sure how that got through the GitLab CI though, maybe there was some caching going on 🤷.
Just one typo I noticed, otherwise very happy to get this in
Co-authored-by: Harry Saunders <[email protected]>
Co-authored-by: Harry Saunders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial set of changes to pull this hook into GitHub.