This repository has been archived by the owner on May 14, 2024. It is now read-only.
Feature/add driver core limit option #44 #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-clegg-tessella
suggested changes
May 1, 2019
piezo_web_app/PiezoWebApp/src/services/spark_job/validation/argument_validator.py
Outdated
Show resolved
Hide resolved
piezo_web_app/PiezoWebApp/tests/services/spark_job/validation/argument_validator_test.py
Outdated
Show resolved
Hide resolved
robert-clegg-tessella
approved these changes
May 1, 2019
|
System tests should still be run before merging this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the optional parameters so that users can set the driver pod and executor pods cpu limit. This controls the amount of cpu any of the spark applications can use while it was previously unrestricted. The spark operator accepts these limits in units of millicpu (e.g."300m" for 300 millicpu), however, the spark operator accepts the cpu requests in terms of a decimal quantity of cpu (e.g. 0.3 for 0.3 cpu = 300m = 300 millicpu). As this is how we have already implemented the argument for cpu request we have used the same units in for the new parameters. Note, when not specified the default value is passed straight from the validation rules to the spark operator and thus must be in units of millicpu.
#44