Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Implement new suite of bootstrap current scalings #3355

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

chris-ashe
Copy link
Collaborator

Description

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe added Physics Relating to the physics models Bootstrap Current Bootstrap current generated by the plasma labels Oct 22, 2024
@chris-ashe chris-ashe linked an issue Oct 22, 2024 that may be closed by this pull request
@chris-ashe chris-ashe changed the title Implement new suite of bootstrap current scalings 🚧 Implement new suite of bootstrap current scalings Oct 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 15.45455% with 93 lines in your changes missing coverage. Please review.

Project coverage is 27.95%. Comparing base (b68ac63) to head (9e57e4c).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
process/io/plot_proc.py 1.92% 51 Missing ⚠️
process/physics.py 26.31% 42 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3355      +/-   ##
==========================================
+ Coverage   27.11%   27.95%   +0.83%     
==========================================
  Files          76       76              
  Lines       17736    18879    +1143     
==========================================
+ Hits         4810     5278     +468     
- Misses      12926    13601     +675     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Add calculation of volume averaged pressure in plasma_profiles.md. This also add the core pressure and volume averaged pressure to the output. Assuming a parabolic profile
- Implement bootstrap fraction calculation using Andrade et al formula in physics.py. This is currently implemented and exported with no tests and notes of applicability regimes
- Add calculation of volume averaged pressure in plasma_profiles.md. This also add the core pressure and volume averaged pressure to the output. Assuming a parabolic profile
- Implement bootstrap fraction calculation using Andrade et al formula in physics.py. This is currently implemented and exported with no tests and notes of applicability regimes
@chris-ashe chris-ashe force-pushed the 3344-implement-suite-of-new-bootstrap-current-scalings branch from 54c4cb3 to 9e57e4c Compare October 24, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bootstrap Current Bootstrap current generated by the plasma Physics Relating to the physics models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement suite of new bootstrap current scalings
2 participants