Skip to content

Commit

Permalink
conan-io#123 Update KB number to 35
Browse files Browse the repository at this point in the history
Signed-off-by: Uilian Ries <[email protected]>
  • Loading branch information
uilianries committed Nov 1, 2019
1 parent 935e847 commit 754b2ef
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions hooks/conan-center.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"KB-H029": "TEST PACKAGE - RUN ENVIRONMENT",
"KB-H030": "CONANDATA.YML FORMAT",
"KB-H031": "CONANDATA.YML REDUCE",
"KB-H034": "CUSTOM ATTRIBUTES",
"KB-H035": "CUSTOM ATTRIBUTES",
}


Expand Down Expand Up @@ -320,7 +320,7 @@ def _not_allowed_entries(info, allowed_entries):
"conandata.yml" % (entries, version))
return

@run_test("KB-H034", output)
@run_test("KB-H035", output)
def test(out):
mock = ConanFile(conanfile.output, None)
valid_attrs = [attr for attr in dir(mock) if not callable(attr)] + ['conan_data', 'python_requires']
Expand Down
8 changes: 4 additions & 4 deletions tests/test_hooks/conan-center/test_conan-center.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def test_conanfile(self):
self.assertIn("ERROR: [CONAN CENTER INDEX URL (KB-H027)] The attribute 'url' should " \
"point to: https://github.com/conan-io/conan-center-index", output)
self.assertIn("[CMAKE MINIMUM VERSION (KB-H028)] OK", output)
self.assertIn("[CUSTOM ATTRIBUTES (KB-H034)] OK", output)
self.assertIn("[CUSTOM ATTRIBUTES (KB-H035)] OK", output)

def test_conanfile_header_only(self):
tools.save('conanfile.py', content=self.conanfile_header_only)
Expand All @@ -110,7 +110,7 @@ def test_conanfile_header_only(self):
"recipe", output)
self.assertIn("[META LINES (KB-H025)] OK", output)
self.assertIn("[CMAKE MINIMUM VERSION (KB-H028)] OK", output)
self.assertIn("[CUSTOM ATTRIBUTES (KB-H034)] OK", output)
self.assertIn("[CUSTOM ATTRIBUTES (KB-H035)] OK", output)

def test_conanfile_header_only_with_settings(self):
tools.save('conanfile.py', content=self.conanfile_header_only_with_settings)
Expand All @@ -131,7 +131,7 @@ def test_conanfile_header_only_with_settings(self):
"recipe", output)
self.assertIn("[META LINES (KB-H025)] OK", output)
self.assertIn("[CMAKE MINIMUM VERSION (KB-H028)] OK", output)
self.assertIn("[CUSTOM ATTRIBUTES (KB-H034)] OK", output)
self.assertIn("[CUSTOM ATTRIBUTES (KB-H035)] OK", output)

def test_conanfile_installer(self):
tools.save('conanfile.py', content=self.conanfile_installer)
Expand Down Expand Up @@ -424,6 +424,6 @@ def package(self):
""")
tools.save('conanfile.py', content=conanfile)
output = self.conan(['create', '.', 'name/version@user/test'])
self.assertIn("ERROR: [CUSTOM ATTRIBUTES (KB-H034)] Custom attributes must be declared " \
self.assertIn("ERROR: [CUSTOM ATTRIBUTES (KB-H035)] Custom attributes must be declared " \
"as protected. The follow attributes are invalid: 'foobar', " \
"'package_subfolder'", output)

0 comments on commit 754b2ef

Please sign in to comment.