Select - Updates select mechanism, table styling, and adds tests. #15
Conversation
| <div class="select-all-action-container" | ||
| ng-show="selected.moreResults()"> | ||
| All {{ table.offset }} results shown are currently selected. | ||
| <a class="table-select-all-action">Select all {{ table.total }} results.</a> |
There was a problem hiding this comment.
Wondering, if it makes sense to say user that he has selected all options and give him option to "select all". And if I deselect one row, this options disappears. It looks that it needs to be vice-versa - when I don't have selected all, I have option to actually select all.
There was a problem hiding this comment.
Happens when I check all (from the left top) - the message says: "All results shown are currently selected. Select all results."
There was a problem hiding this comment.
This action was intended from this scenario
- I have 50 of 100 results showing
- I clicked the 'select all' checkbox, which selected all 50 visible to perform some action
- Maybe I really want to perform that action on all 100
This link appears and gives them that option. It's similar to how gmail handles when you select all.
There was a problem hiding this comment.
OK, this makes sense. Actually the sentence "Select all 100 results" as is done in the code would help, however it seems that total number is not working in the example.
|
Smaller comments inline, after fixing these ACK. |
No description provided.