Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Typo in volume in a gli; changed AREA to GEOMETRY_AREA in some mmp #26

Merged
merged 3 commits into from
Jan 23, 2019
Merged

Bugfix: Typo in volume in a gli; changed AREA to GEOMETRY_AREA in some mmp #26

merged 3 commits into from
Jan 23, 2019

Conversation

MuellerSeb
Copy link
Member

found with ogs5py

@MuellerSeb
Copy link
Member Author

https://github.com/GeoStat-Framework/ogs5py_benchmarks/blob/master/benchmarks_FEM_active/LOG.txt#L202

@wenqing
Copy link
Member

wenqing commented Jan 21, 2019

@MuellerSeb Nice.
It is better to remove that VOLUME entity in gli because it is not used anywhere in the input data.

@MuellerSeb MuellerSeb changed the title Bugfix: Typo in volume Bugfix: Typo in volume in a gli; changed AREA to GEOMETRY_AREA in some mmp Jan 21, 2019
@MuellerSeb
Copy link
Member Author

@wenqing but I think the output is different after the change.
I added the sub-keyword change to this pull-request. See: #27

@wenqing
Copy link
Member

wenqing commented Jan 21, 2019

@MuellerSeb I am going to check the output.

@MuellerSeb
Copy link
Member Author

@wenqing : My Fault! The output is the same on my machine. I compared the wrong files. So should I remove this volume, right?

@wenqing wenqing merged commit 7ff69f6 into ufz:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MuellerSeb @wenqing