-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GEFS regression test suite from EP5r2 configuration/case #2442
base: develop
Are you sure you want to change the base?
Add GEFS regression test suite from EP5r2 configuration/case #2442
Conversation
…esn't run with namelist error
Are the versions of PIO, netcdf-fortran, netcdf-c, and HDF5 all the same on hercules as on other platforms? |
Hi @edwardhartnett. Hercules is maybe the only platform reliably running gnu tests right now. I see the same gnu and intel libraries via spack-stack-1.6.0 on hercules: |
OK, I thought we had switched to hdf5-1.14.3? Some parallel I/O bugs were fixed in HDF5-1.14.3. |
@edwardhartnett We can test with updated packages. What versions would you suggest? |
hdf5-1.14.3 |
Alternate solution is to add glo_025 files to WW3 input data but there is some customization to elementMask
# decomposition gefs test | ||
# | ||
|
||
source ${PATHRT}/tests/cpld_control_gefs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty big departure from how tests are set up currently. The advantage of the current system is that you can just diff two tests and more easily see the differences from defaults. Here the non-default settings are one-step removed from the default_vars. The disadvantage w/ the current way we do is is that you have a lot of settings carried over. @BrianCurtis-NOAA do you have any comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Maybe I should mention this more follows the ORTs:
https://github.com/ufs-community/ufs-weather-model/blob/develop/tests/opnReqTests/dcp.sh
but it's not clear current ORT setup is being/will be maintained
Commit Queue Requirements:
Description:
This PR updates the cpld_bmark_p8 tests to a prototype GEFS test case of fully coupled s2swa+IAU+stochastics in atmosphere and ocean, with configuration and warm starts from restarts of EP5r2 ensemble member 1 for 2021-03-25 06Z. The EP5r2 test case was kindly provided by @bingfu-NOAA via @junwang-noaa with aerosol input data and configurations from @lipan-NOAA.
A separate INPUTDATA_ROOT_BMIC is no longer needed and is removed.
The regression test suite samples basic reproducibility/quality checks, particularly:
All tests do not pass across all platforms, summarized in this regression test suite matrix:
and summary slides on pre-test and common issues.
Some tests fail in common. This commit helps share reproducers to follow up on remaining issues. User needs to uncomment these tests to run. Failures may require library/platform support. Hopefully committing this test suite as work in progress facilitates collaborative development particularly in:
Note that there are two intentional differences from GEFS workflow configuration (please inform if you see other differences): 1) aerosols are 1-way coupled in diagnostic mode and 2) wave element mask has been modified as discussed in NOAA-EMC/WW3#1328.
In the future, depending on aerosol coupling, GOCART .rc files and ExtData directory structure may be revised for consistency with global-workflow. This benchmark configuration and case may be updated as well, particularly with GEFS reforecast or UFS case study.
TODO: Scripts need finalizing once filepaths are in shared space.
Input data is currently in user space on hera:
/scratch1/NCEPDEV/nems/Nick.Szapiro/tasks/input_data/gefs.v13/RT_GEFS/
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: