Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state managerがSIGTERMなどを受けてgraceful shutdownするようにした #208

Merged
merged 6 commits into from
Nov 10, 2023

Conversation

Azuki-bar
Copy link
Member

close #207

goroutineにcontextを渡して、適切にハンドルするようにした

またerrGroupを使ってmain関数で走らせているgoroutine同士にもキャンセルが伝播するようにした

@Azuki-bar Azuki-bar requested a review from csenet November 9, 2023 12:17
@github-actions github-actions bot added the backend バックエンド関連 label Nov 9, 2023
@Azuki-bar Azuki-bar changed the title state managerがos.Signalを受けてgraceful shutdownするようにした state managerがSIGTERMなどを受けてgraceful shutdownするようにした Nov 9, 2023
@Azuki-bar Azuki-bar self-assigned this Nov 9, 2023
Copy link
Member

@csenet csenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです
ありがとうございます

@Azuki-bar
Copy link
Member Author

わいわい
ありがとうございます

@Azuki-bar Azuki-bar merged commit 29134ad into main Nov 10, 2023
3 checks passed
@Azuki-bar Azuki-bar deleted the impl-graceful-shutdowm branch November 10, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend バックエンド関連
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State managerがgracedul shutdownできるようにする
2 participants