Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not hard-code API base URL #18

Merged
merged 1 commit into from
Aug 25, 2023
Merged

do not hard-code API base URL #18

merged 1 commit into from
Aug 25, 2023

Conversation

otariidae
Copy link

READMEに書かれてた VERIFY_API_URL が実は使われてなかったのを見つけたので、代わりに CARD_MANAGER_BASE_URL として実装

@otariidae otariidae requested a review from csenet August 22, 2023 11:31
Copy link
Member

@csenet csenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ありがとうございます

@otariidae otariidae merged commit 1a3a61f into main Aug 25, 2023
1 check passed
@otariidae otariidae deleted the api-env branch August 25, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants