Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 590: Warn if an AlternateDataStream instance is not also a FileSystemObject #604

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Issue 590: Warn if an AlternateDataStream instance is not also a FileSystemObject #604

merged 2 commits into from
Jun 5, 2024

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented May 10, 2024 •
edited
Loading

This Pull Request resolves all backwards-compatible requirements of Issue #590 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop
  • CI passes in UCO current unstable branch (afb1aab)
  • CI passes in CASE current unstable branch tracking UCO's unstable as submodule (5e28bdd)
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora (N/A)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples (N/A)
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io (N/A)
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue

@ajnelson-nist
Warn if an AlternateDataStream instance is not also a FileSystemObject
13f877b 
A follow-on patch will regenerate Make-managed files.

References:
* #590

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist
Regenerate Make-managed files
5a40aa4 
References:
* #590

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist ajnelson-nist added this to the UCO 1.4.0 milestone May 10, 2024
@ajnelson-nist ajnelson-nist linked an issue May 10, 2024 that may be closed by this pull request
observable:AlternateDataStream is not a subclass of FileSystemObject, but File and ReparsePoint are #590
Closed
14 tasks
@ajnelson-nist ajnelson-nist mentioned this pull request May 10, 2024
Closed
14 tasks
@ajnelson-nist
Copy link
Contributor Author

This PR is ready for review and merge.

@ajnelson-nist ajnelson-nist marked this pull request as ready for review June 5, 2024 10:28
@ajnelson-nist ajnelson-nist mentioned this pull request Jun 5, 2024
Merged
15 tasks
plbt5
plbt5 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@plbt5 plbt5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only vaguely understand what is being tried to achieve, i.e., bridging operational use of current UCO versions until v.2.0.0 while already preparing a breaking change with the current and in between versions towards 2.0.0
Additionally, I only have a vague understanding on how that is achieved, but I can see that there is test code for it that I assume is doing what it is supposed to.
In short, I do approve but I don't know what exactly.

@plbt5 plbt5 merged commit fde4cdd into develop Jun 5, 2024
1 check passed
@plbt5 plbt5 deleted the BugFix-Issue-590 branch June 5, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbt5 plbt5 plbt5 approved these changes

Assignees
No one assigned
Labels
Change Proposal
Projects
None yet
Milestone
UCO 1.4.0
Development

Successfully merging this pull request may close these issues.

observable:AlternateDataStream is not a subclass of FileSystemObject, but File and ReparsePoint are
2 participants
@ajnelson-nist @plbt5