Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 573: Warn if target or source on an ObservableRelationship are not Observables #574

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Issue 573: Warn if target or source on an ObservableRelationship are not Observables #574

merged 1 commit into from
Apr 30, 2024

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Dec 21, 2023 •
edited
Loading

This Pull Request resolves all backwards-compatible requirements of Issue #573 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop
  • CI passes in UCO current unstable branch (c30810b )
  • CI passes in CASE current unstable branch tracking UCO's unstable as submodule (aa76a50 )
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora (N/A)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

@ajnelson-nist
Warn if target or source on an ObservableRelationship are not Observa…
6160019 
…bles

No effects were observed on Make-managed files.

References:
* #573

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist ajnelson-nist added this to the UCO 1.x.0 milestone Dec 21, 2023
@ajnelson-nist ajnelson-nist linked an issue Dec 21, 2023 that may be closed by this pull request
observable:ObservableRelationship should constrain the types on the objects it is relating #573
Closed
16 tasks
@ajnelson-nist ajnelson-nist modified the milestones: UCO 1.x.0, UCO 1.4.0 Dec 21, 2023
@ajnelson-nist
Copy link
Contributor Author

CASE-Examples and the CASE website both have a few ObservableRelationship objects that could be impacted by the results of the "Just one Observable, or both Observables?" discussion on Issue 573.

@ajnelson-nist ajnelson-nist mentioned this pull request Apr 25, 2024
Closed
16 tasks
@ajnelson-nist
Copy link
Contributor Author

This PR is ready for review and merge.

@ajnelson-nist ajnelson-nist marked this pull request as ready for review April 29, 2024 18:13
@ajnelson-nist ajnelson-nist requested a review from a team April 29, 2024 18:13
@plbt5 plbt5 merged commit 27ca6b0 into develop Apr 30, 2024
1 check passed
@plbt5 plbt5 deleted the Feature-Issue-573 branch April 30, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbt5 plbt5 plbt5 approved these changes

Assignees
No one assigned
Labels
Change Proposal
Projects
None yet
Milestone
UCO 1.4.0
Development

Successfully merging this pull request may close these issues.

observable:ObservableRelationship should constrain the types on the objects it is relating
2 participants
@ajnelson-nist @plbt5