Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of sh:declare #463

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Aug 19, 2022

This is filed as a bugfix Pull Request due to a discovery made in Issue #457 .

SHACL Specification Section 5.2.1 specifies a "viral" behavior of sh:declare throughout an OWL transitive closure. This patch removes usage of sh:declare as a matter of lack of authority for non-UCO prefixes. It just so happens the only place this was used was in the introduction of the OWL SHACL review mechanisms of Issue 406.

Coordination

  • Tracking in Jira ticket OC-268
  • Pull request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed.
  • CI passes in (CASE/UCO) feature branch
  • CI passes in (CASE/UCO) current unstable branch (4a99851)
  • CI passes in CASE current unstable branch tracking UCO's unstable as submodule (8f6ffd4)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples (N/A)
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io (N/A)
  • Solutions Approval vote logged on corresponding Issue (N/A under bugfix workflow)

SHACL Specification Section 5.2.1 specifies a "viral" behavior of
`sh:declare` throughout an OWL transitive closure.  This patch removes
usage of `sh:declare` as a matter of lack of authority for non-UCO
prefixes.  It just so happens the only place this was used was in the
introduction of the OWL SHACL review mechanisms of Issue 406.

A follow-on patch will regenerate Make-managed files.

References:
* #406
* #457

Signed-off-by: Alex Nelson <[email protected]>
References:
* #406
* #457

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist ajnelson-nist added this to the UCO 1.0.0 milestone Aug 19, 2022
ajnelson-nist added a commit to casework/CASE-Examples that referenced this pull request Aug 19, 2022
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#463

Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist added a commit to casework/casework.github.io that referenced this pull request Aug 19, 2022
A follow-on patch will regenerate Make-managed files.

References:
* ucoProject/UCO#463

Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist added a commit to casework/casework.github.io that referenced this pull request Aug 19, 2022
References:
* ucoProject/UCO#463

Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist added a commit to frederich-stine/UCO that referenced this pull request Aug 19, 2022
A pattern implemented in PR 463 is to avoid `sh:declare`, and where
prefixes are needed in SHACL-SPARQL queries, to inline a PREFIX clause.

This patch removes one instance of `sh:prefixes` that is not addressed
by PR 463.

References:
* ucoProject#435
* ucoProject#463

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist
Copy link
Contributor Author

Converting to draft while checking for CASE unstable branch impact.

@ajnelson-nist ajnelson-nist marked this pull request as draft August 21, 2022 16:32
@ajnelson-nist
Copy link
Contributor Author

CI has passed in CASE's unstable. This is ready for review and merge.

@ajnelson-nist ajnelson-nist marked this pull request as ready for review August 22, 2022 14:49
@b0bkaT b0bkaT merged commit d685e83 into develop Aug 22, 2022
@ajnelson-nist ajnelson-nist deleted the BugFix-Issue-406-remove-sh-declare branch August 22, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants