Cut errant rdf:List artifact #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somewhere in the chain between core rdflib, pyshacl, and rdf-toolkit.jar, the normalized Turtle content sometimes picks up redundant list artifacts that vary between runs. The anonymous list cut in this patch has been seen to waver in how much of it is left as a detached blank node. This patch removes the orphaned list. Guidance needs to be provided that, as long as this bug in the tool stack persists, the Make-managed generated output should not have it Git-tracked. References: * #406 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
changed the title
ajnelson-nist
added a commit
to casework/casework.github.io
that referenced
this pull request
Aug 18, 2022
No effects were observed on Make-managed files. References: * ucoProject/UCO#424 * ucoProject/UCO#456 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to casework/CASE-Examples
that referenced
this pull request
Aug 18, 2022
This is the result of running `make`, seeing errant changes as reported
in UCO PR 456, and going through and removing all generated `rdf:List`
occurrences found with this command:
grep -R 'rdf:first' *
References:
ucoProject/UCO#456
Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to casework/CASE-Examples
that referenced
this pull request
Aug 18, 2022
This is the result of running `make`, seeing errant changes as reported
in UCO PR 456, and going through and removing all generated `rdf:List`
occurrences found with this command:
grep -R 'rdf:first' *
References:
* ucoProject/UCO#456
Signed-off-by: Alex Nelson <[email protected]>
|
I am aware this can potentially cause some merge conflicts for incoming proposals to UCO's |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request is a cleanup to side effects from what is currently suspected to have come from either Issue #406 , from an unrealized effect in the release of
rdflib6.2.0, or both. The submitter believes risk from adoption, to UCO and downstream ontologies, is zero.Somewhere in the chain between core
rdflib,pyshacl, andrdf-toolkit.jar, the normalized Turtle content sometimes picks up redundantrdf:Listartifacts that vary between runs. The anonymous list cut in this patch has been seen to waver in how much of it is left as a detached blank node, here and in other CASE examples.The first patch in this PR removes the orphaned list. Guidance needs to be provided that, as long as this bug in the tool stack persists, the Make-managed generated output should not have it Git-tracked.
Review steps taken: